From 94db2c0a6930ca5c2dba6cfce404fc1e94e4f593 Mon Sep 17 00:00:00 2001
From: D025 <maksym.kryva@gmail.com>
Date: Tue, 12 Mar 2024 17:06:09 +0200
Subject: [PATCH] feat!: remove node exporter from monitoring stack (#9)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## What ❔
Remove node exporter from monitoring

## Why ❔
Redundant for this context

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Documentation comments have been added / updated.
---
 README.md                       |  2 +-
 defaults/main.yml               |  1 -
 templates/monitoring.yaml.j2    | 12 ------------
 templates/vmagent-config.yml.j2 |  8 --------
 4 files changed, 1 insertion(+), 22 deletions(-)

diff --git a/README.md b/README.md
index 640332c..1e09f9c 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 # ansible-en-role
 
-Ansible role to deploy and configure zkSync Era External Node, including DB instance setup on the same machine, Traefik as reverse proxy, and Prometheus monitoring (PostgreSQL exporter, Node exporter, cAdvisor, Traefik, External Node native metrics, and VictoriaMetrics vmagent to scrape all of them).
+Ansible role to deploy and configure zkSync Era External Node, including DB instance setup on the same machine, Traefik as reverse proxy, and Prometheus monitoring (PostgreSQL exporter, cAdvisor, Traefik, External Node native metrics, and VictoriaMetrics vmagent to scrape all of them).
 
 Make sure to configure Prometheus remote write endpoint to send metrics to centralized metrics storage.
 
diff --git a/defaults/main.yml b/defaults/main.yml
index 3acd7b1..acae1df 100644
--- a/defaults/main.yml
+++ b/defaults/main.yml
@@ -13,7 +13,6 @@ traefik_version: 2.11
 postgres_version: 14
 external_node_version: 21.0.2
 vmagent_version: 1.95.1
-node_exporter_version: 1.7.0
 cadvisor_version: 0.47.2
 postgres_exporter_version: 0.15.0
 
diff --git a/templates/monitoring.yaml.j2 b/templates/monitoring.yaml.j2
index 836986f..ba5f149 100644
--- a/templates/monitoring.yaml.j2
+++ b/templates/monitoring.yaml.j2
@@ -21,18 +21,6 @@ services:
       - "--remoteWrite.vmProtoCompressLevel=2"
     restart: always
 
-  node-exporter:
-    image: "prom/node-exporter:v{{ node_exporter_version }}"
-    volumes:
-      - /proc:/host/proc:ro
-      - /sys:/host/sys:ro
-      - /:/rootfs:ro
-    restart: unless-stopped
-    command:
-      - '--path.procfs=/host/proc'
-      - '--path.sysfs=/host/sys'
-      - '--collector.filesystem.ignored-mount-points=^/(sys|proc|dev|host|etc)($$|/)'
-
   cadvisor:
     image: "gcr.io/cadvisor/cadvisor:v{{ cadvisor_version }}"
     volumes:
diff --git a/templates/vmagent-config.yml.j2 b/templates/vmagent-config.yml.j2
index 31781eb..db5a52d 100644
--- a/templates/vmagent-config.yml.j2
+++ b/templates/vmagent-config.yml.j2
@@ -14,14 +14,6 @@ scrape_configs:
       - source_labels: [instance]
         target_label: instance
         replacement: '{{ node_name | mandatory }}'
-  - job_name: node-exporter
-    static_configs:
-      - targets:
-          - "node-exporter:9100"
-    relabel_configs:
-      - source_labels: [instance]
-        target_label: instance
-        replacement: '{{ node_name | mandatory }}'
   - job_name: cadvisor
     static_configs:
       - targets: