jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(storage): fix flaky read transaction safety (#6995)

Browse Source
This commit is contained in:
Alexey Shekhirin
2024-03-06 11:35:35 +00:00
committed by GitHub
parent 588c2f2e6a
commit 0633fa569e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/storage/db/src/implementation/mdbx/tx.rs
View File

@ -244,7 +244,7 @@ impl<K: TransactionKind> MetricsHandler<K> {
self.transaction_mode().is_read_only()
{
let open_duration = self.start.elapsed();
if open_duration > self.long_transaction_duration {
if open_duration >= self.long_transaction_duration {
self.backtrace_recorded.store(true, Ordering::Relaxed);
warn!(
target: "storage::db::mdbx",
@ -412,7 +412,8 @@ mod tests {
let mut tx = db.tx().unwrap();
tx.metrics_handler.as_mut().unwrap().long_transaction_duration = MAX_DURATION;
tx.disable_long_read_transaction_safety();
sleep(MAX_DURATION);
// Give the `TxnManager` some time to time out the transaction.
sleep(MAX_DURATION + Duration::from_millis(100));
assert_eq!(
tx.get::<tables::Transactions>(0).err(),
@ -433,7 +434,8 @@ mod tests {
let mut tx = db.tx().unwrap();
tx.metrics_handler.as_mut().unwrap().long_transaction_duration = MAX_DURATION;
sleep(MAX_DURATION);
// Give the `TxnManager` some time to time out the transaction.
sleep(MAX_DURATION + Duration::from_millis(100));
assert_eq!(
tx.get::<tables::Transactions>(0).err(),