jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(cli): enable witness invalid block hook by default (#10839)

Browse Source
This commit is contained in:
Alexey Shekhirin
2024-09-17 15:44:28 +01:00
committed by GitHub
parent ad76d89a27
commit 0746479e3c
2 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
book/cli/reth/node.md vendored
View File

@ -545,6 +545,7 @@ Debug:
Example: `witness,prestate` Example: `witness,prestate`
[default: witness]
[possible values: witness, pre-state, opcode] [possible values: witness, pre-state, opcode]
--debug.healthy-node-rpc-url <URL> --debug.healthy-node-rpc-url <URL>

34
crates/node/core/src/args/debug.rs
View File

@ -9,7 +9,7 @@ use std::{collections::HashSet, ffi::OsStr, fmt, path::PathBuf, str::FromStr};
use strum::{AsRefStr, EnumIter, IntoStaticStr, ParseError, VariantArray, VariantNames}; use strum::{AsRefStr, EnumIter, IntoStaticStr, ParseError, VariantArray, VariantNames};
/// Parameters for debugging purposes /// Parameters for debugging purposes
#[derive(Debug, Clone, Args, PartialEq, Eq, Default)] #[derive(Debug, Clone, Args, PartialEq, Eq)]
#[command(next_help_heading = "Debug")] #[command(next_help_heading = "Debug")]
pub struct DebugArgs { pub struct DebugArgs {
/// Flag indicating whether the node should be terminated after the pipeline sync. /// Flag indicating whether the node should be terminated after the pipeline sync.
@ -71,7 +71,12 @@ pub struct DebugArgs {
/// Determines which type of invalid block hook to install /// Determines which type of invalid block hook to install
/// ///
/// Example: `witness,prestate` /// Example: `witness,prestate`
#[arg(long = "debug.invalid-block-hook", help_heading = "Debug", value_parser = InvalidBlockSelectionValueParser::default())] #[arg(
long = "debug.invalid-block-hook",
help_heading = "Debug",
value_parser = InvalidBlockSelectionValueParser::default(),
default_value = "witness"
)]
pub invalid_block_hook: Option<InvalidBlockSelection>, pub invalid_block_hook: Option<InvalidBlockSelection>,
/// The RPC URL of a healthy node to use for comparing invalid block hook results against. /// The RPC URL of a healthy node to use for comparing invalid block hook results against.
@ -84,6 +89,25 @@ pub struct DebugArgs {
pub healthy_node_rpc_url: Option<String>, pub healthy_node_rpc_url: Option<String>,
} }
impl Default for DebugArgs {
fn default() -> Self {
Self {
terminate: false,
tip: None,
max_block: None,
etherscan: None,
rpc_consensus_ws: None,
skip_fcu: None,
skip_new_payload: None,
reorg_frequency: None,
reorg_depth: None,
engine_api_store: None,
invalid_block_hook: Some(InvalidBlockSelection::default()),
healthy_node_rpc_url: None,
}
}
}
/// Describes the invalid block hooks that should be installed. /// Describes the invalid block hooks that should be installed.
/// ///
/// # Example /// # Example
@ -97,6 +121,12 @@ pub struct DebugArgs {
#[derive(Debug, Clone, PartialEq, Eq, derive_more::Deref)] #[derive(Debug, Clone, PartialEq, Eq, derive_more::Deref)]
pub struct InvalidBlockSelection(HashSet<InvalidBlockHookType>); pub struct InvalidBlockSelection(HashSet<InvalidBlockHookType>);
impl Default for InvalidBlockSelection {
fn default() -> Self {
Self([InvalidBlockHookType::Witness].into())
}
}
impl InvalidBlockSelection { impl InvalidBlockSelection {
/// Creates a new _unique_ [`InvalidBlockSelection`] from the given items. /// Creates a new _unique_ [`InvalidBlockSelection`] from the given items.
/// ///