jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(revm): remove local thread for pipeline execution stage (#5082)

Browse Source
This commit is contained in:
rakita
2023-10-19 13:12:06 +02:00
committed by GitHub
parent 38e0d5ae61
commit 0aeb0b622a
1 changed files with 1 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
crates/stages/src/stages/execution.rs
View File

@ -326,13 +326,6 @@ fn calculate_gas_used_from_headers<DB: Database>(
Ok(gas_total) Ok(gas_total)
} }
/// The size of the stack used by the executor.
///
/// Ensure the size is aligned to 8 as this is usually more efficient.
///
/// Currently 64 megabytes.
const BIG_STACK_SIZE: usize = 64 * 1024 * 1024;
#[async_trait::async_trait] #[async_trait::async_trait]
impl<EF: ExecutorFactory, DB: Database> Stage<DB> for ExecutionStage<EF> { impl<EF: ExecutorFactory, DB: Database> Stage<DB> for ExecutionStage<EF> {
/// Return the id of the stage /// Return the id of the stage
@ -346,25 +339,7 @@ impl<EF: ExecutorFactory, DB: Database> Stage<DB> for ExecutionStage<EF> {
provider: &DatabaseProviderRW<'_, &DB>, provider: &DatabaseProviderRW<'_, &DB>,
input: ExecInput, input: ExecInput,
) -> Result<ExecOutput, StageError> { ) -> Result<ExecOutput, StageError> {
// For Ethereum transactions that reaches the max call depth (1024) revm can use more stack
// space than what is allocated by default.
//
// To make sure we do not panic in this case, spawn a thread with a big stack allocated.
//
// A fix in revm is pending to give more insight into the stack size, which we can use later
// to optimize revm or move data to the heap.
//
// See https://github.com/bluealloy/revm/issues/305
std::thread::scope(|scope| {
let handle = std::thread::Builder::new()
.stack_size(BIG_STACK_SIZE)
.spawn_scoped(scope, || {
// execute and store output to results
self.execute_inner(provider, input) self.execute_inner(provider, input)
})
.expect("Expects that thread name is not null");
handle.join().expect("Expects for thread to not panic")
})
} }
/// Unwind the stage. /// Unwind the stage.