jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

style: rm redundant Pipeline::new (#682)

Browse Source
This commit is contained in:
Matthias Seitz
2023-01-02 14:58:31 +01:00
committed by GitHub
parent ec69481af4
commit 13441ff299
2 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bin/reth/src/node/mod.rs
View File

@ -118,7 +118,7 @@ impl Command {
// cloneable on its own
// TODO: Remove magic numbers
let fetch_client = Arc::new(network.fetch_client().await?);
let mut pipeline = reth_stages::Pipeline::new()
let mut pipeline = reth_stages::Pipeline::default()
.push(HeaderStage {
downloader: headers::linear::LinearDownloadBuilder::default()
.batch_size(config.stages.headers.downloader_batch_size)

19
crates/stages/src/pipeline.rs
View File

@ -88,14 +88,9 @@ impl<DB: Database> Debug for Pipeline<DB> {
}
impl<DB: Database> Pipeline<DB> {
/// Create a new pipeline.
pub fn new() -> Self {
Default::default()
}
/// Create a new pipeline with a channel for receiving events (see [PipelineEvent]).
pub fn new_with_channel(sender: Sender<PipelineEvent>) -> Self {
Self::new().set_channel(sender)
pub fn with_channel(sender: Sender<PipelineEvent>) -> Self {
Self::default().set_channel(sender)
}
/// Add a stage to the pipeline.
@ -371,7 +366,7 @@ mod tests {
// Run pipeline
tokio::spawn(async move {
Pipeline::<Env<WriteMap>>::new_with_channel(tx)
Pipeline::<Env<WriteMap>>::with_channel(tx)
.push(
TestStage::new(StageId("A"))
.add_exec(Ok(ExecOutput { stage_progress: 20, done: true })),
@ -411,7 +406,7 @@ mod tests {
// Run pipeline
tokio::spawn(async move {
let mut pipeline = Pipeline::<Env<mdbx::WriteMap>>::new()
let mut pipeline = Pipeline::<Env<mdbx::WriteMap>>::default()
.push(
TestStage::new(StageId("A"))
.add_exec(Ok(ExecOutput { stage_progress: 100, done: true }))
@ -487,7 +482,7 @@ mod tests {
// Run pipeline
tokio::spawn(async move {
Pipeline::<Env<mdbx::WriteMap>>::new()
Pipeline::<Env<mdbx::WriteMap>>::default()
.push(
TestStage::new(StageId("A"))
.add_exec(Ok(ExecOutput { stage_progress: 10, done: true }))
@ -548,7 +543,7 @@ mod tests {
async fn pipeline_error_handling() {
// Non-fatal
let db = test_utils::create_test_db(EnvKind::RW);
let result = Pipeline::<Env<WriteMap>>::new()
let result = Pipeline::<Env<WriteMap>>::default()
.push(
TestStage::new(StageId("NonFatal"))
.add_exec(Err(StageError::Recoverable(Box::new(std::fmt::Error))))
@ -561,7 +556,7 @@ mod tests {
// Fatal
let db = test_utils::create_test_db(EnvKind::RW);
let result = Pipeline::<Env<WriteMap>>::new()
let result = Pipeline::<Env<WriteMap>>::default()
.push(TestStage::new(StageId("Fatal")).add_exec(Err(StageError::DatabaseIntegrity(
DatabaseIntegrityError::BlockBody { number: 5 },
))))