jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 19:09:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(db): Dont compress DupSort SubKey (#594)

Browse Source 
* bug(db): Dont compress DupSort SubKey

* unwrap or default config, Added notes

* fmt empty lines
This commit is contained in:
rakita
2022-12-25 01:13:03 +01:00
committed by GitHub
parent 5affa67805
commit 19a618e3a4
4 changed files with 49 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
crates/storage/db/src/tables/models/accounts.rs
View File

@ -6,14 +6,11 @@ use crate::{
Error,
};
use bytes::Bytes;
use reth_codecs::{main_codec, Compact};
use reth_codecs::Compact;
use reth_primitives::{Account, Address, TransitionId};
use serde::{Deserialize, Serialize};
/// Account as it is saved inside [`AccountChangeSet`]. [`Address`] is the subkey.
/// TODO there should be `not_existing` boolean or Account be made as `Option` to
/// handle scenario where account was not present before transaction.
#[main_codec]
#[derive(Debug, Default, Clone, Eq, PartialEq)]
pub struct AccountBeforeTx {
/// Address for the account. Acts as `DupSort::SubKey`.
@ -22,6 +19,26 @@ pub struct AccountBeforeTx {
pub info: Option<Account>,
}
// NOTE: Removing main_codec and manually encode subkey
// and compress second part of the value. If we have compression
// over whole value (Even SubKey) that would mess up fetching of values with seek_by_key_subkey
impl Compact for AccountBeforeTx {
fn to_compact(self, buf: &mut impl bytes::BufMut) -> usize {
// for now put full bytes and later compress it.
buf.put_slice(&self.address.to_fixed_bytes()[..]);
self.info.to_compact(buf) + 32
}
fn from_compact(buf: &[u8], len: usize) -> (Self, &[u8])
where
Self: Sized,
{
let address = Address::from_slice(&buf[..20]);
let (info, out) = <Option<Account>>::from_compact(&buf[20..], len - 20);
(Self { address, info }, out)
}
}
/// [`TxNumber`] concatenated with [`Address`]. Used as a key for [`StorageChangeSet`]
///
/// Since it's used as a key, it isn't compressed when encoding it.