jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: support ms for --builder.interval (#10168)

Browse Source
This commit is contained in:
Matthias Seitz
2024-08-07 16:33:57 +02:00
committed by GitHub
parent 0fb72762de
commit 1d4638724c
4 changed files with 62 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
crates/node/core/src/args/payload_builder.rs
View File

@ -3,7 +3,7 @@ use clap::{
builder::{RangedU64ValueParser, TypedValueParser},
Arg, Args, Command,
};
use reth_cli_util::parse_duration_from_secs;
use reth_cli_util::{parse_duration_from_secs, parse_duration_from_secs_or_ms};
use reth_primitives::constants::{
ETHEREUM_BLOCK_GAS_LIMIT, MAXIMUM_EXTRA_DATA_SIZE, SLOT_DURATION,
};
@ -21,8 +21,12 @@ pub struct PayloadBuilderArgs {
#[arg(long = "builder.gaslimit", default_value = "30000000", value_name = "GAS_LIMIT")]
pub max_gas_limit: u64,
/// The interval at which the job should build a new payload after the last (in seconds).
#[arg(long = "builder.interval", value_parser = parse_duration_from_secs, default_value = "1", value_name = "SECONDS")]
/// The interval at which the job should build a new payload after the last.
///
/// Interval is specified in seconds or in milliseconds if the value ends with `ms`:
/// * `50ms` -> 50 milliseconds
/// * `1` -> 1 second
#[arg(long = "builder.interval", value_parser = parse_duration_from_secs_or_ms, default_value = "1", value_name = "DURATION")]
pub interval: Duration,
/// The deadline for when the payload builder job should resolve.
@ -154,4 +158,20 @@ mod tests {
let args = CommandParser::<PayloadBuilderArgs>::parse_from(["reth"]).args;
assert_eq!(args, default_args);
}
#[test]
fn test_args_with_s_interval() {
let args =
CommandParser::<PayloadBuilderArgs>::parse_from(["reth", "--builder.interval", "50"])
.args;
assert_eq!(args.interval, Duration::from_secs(50));
}
#[test]
fn test_args_with_ms_interval() {
let args =
CommandParser::<PayloadBuilderArgs>::parse_from(["reth", "--builder.interval", "50ms"])
.args;
assert_eq!(args.interval, Duration::from_millis(50));
}
}