From 2758a560c0ed1afb9b395123eef788e2426b951b Mon Sep 17 00:00:00 2001
From: Darshan Kathiriya <8559992+lakshya-sky@users.noreply.github.com>
Date: Fri, 1 Nov 2024 07:10:55 -0400
Subject: [PATCH] txpool: added a helper to filter pending txns by predicate
 (#12204)

---
 crates/transaction-pool/src/lib.rs         | 7 +++++++
 crates/transaction-pool/src/noop.rs        | 7 +++++++
 crates/transaction-pool/src/pool/mod.rs    | 8 ++++++++
 crates/transaction-pool/src/pool/txpool.rs | 8 ++++++++
 crates/transaction-pool/src/traits.rs      | 6 ++++++
 5 files changed, 36 insertions(+)

diff --git a/crates/transaction-pool/src/lib.rs b/crates/transaction-pool/src/lib.rs
index f8f06b805..020375994 100644
--- a/crates/transaction-pool/src/lib.rs
+++ b/crates/transaction-pool/src/lib.rs
@@ -496,6 +496,13 @@ where
         self.pool.get_transactions_by_sender(sender)
     }
 
+    fn get_pending_transactions_with_predicate(
+        &self,
+        predicate: impl FnMut(&ValidPoolTransaction<Self::Transaction>) -> bool,
+    ) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> {
+        self.pool.pending_transactions_with_predicate(predicate)
+    }
+
     fn get_pending_transactions_by_sender(
         &self,
         sender: Address,
diff --git a/crates/transaction-pool/src/noop.rs b/crates/transaction-pool/src/noop.rs
index 0f87f06f7..47a26ee29 100644
--- a/crates/transaction-pool/src/noop.rs
+++ b/crates/transaction-pool/src/noop.rs
@@ -213,6 +213,13 @@ impl TransactionPool for NoopTransactionPool {
         vec![]
     }
 
+    fn get_pending_transactions_with_predicate(
+        &self,
+        _predicate: impl FnMut(&ValidPoolTransaction<Self::Transaction>) -> bool,
+    ) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> {
+        vec![]
+    }
+
     fn get_pending_transactions_by_sender(
         &self,
         _sender: Address,
diff --git a/crates/transaction-pool/src/pool/mod.rs b/crates/transaction-pool/src/pool/mod.rs
index 2e7340954..77446a523 100644
--- a/crates/transaction-pool/src/pool/mod.rs
+++ b/crates/transaction-pool/src/pool/mod.rs
@@ -787,6 +787,14 @@ where
         self.get_pool_data().pending_txs_by_sender(sender_id)
     }
 
+    /// Returns all pending transactions filtered by predicate
+    pub(crate) fn pending_transactions_with_predicate(
+        &self,
+        predicate: impl FnMut(&ValidPoolTransaction<T::Transaction>) -> bool,
+    ) -> Vec<Arc<ValidPoolTransaction<T::Transaction>>> {
+        self.get_pool_data().pending_transactions_with_predicate(predicate)
+    }
+
     /// Returns all pending transactions of the address by sender
     pub(crate) fn get_pending_transactions_by_sender(
         &self,
diff --git a/crates/transaction-pool/src/pool/txpool.rs b/crates/transaction-pool/src/pool/txpool.rs
index bd0aacccf..8679a4318 100644
--- a/crates/transaction-pool/src/pool/txpool.rs
+++ b/crates/transaction-pool/src/pool/txpool.rs
@@ -364,6 +364,14 @@ impl<T: TransactionOrdering> TxPool<T> {
         self.pending_pool.all()
     }
 
+    /// Returns all pending transactions filtered by predicate
+    pub(crate) fn pending_transactions_with_predicate(
+        &self,
+        mut predicate: impl FnMut(&ValidPoolTransaction<T::Transaction>) -> bool,
+    ) -> Vec<Arc<ValidPoolTransaction<T::Transaction>>> {
+        self.pending_transactions_iter().filter(|tx| predicate(tx)).collect()
+    }
+
     /// Returns all pending transactions for the specified sender
     pub(crate) fn pending_txs_by_sender(
         &self,
diff --git a/crates/transaction-pool/src/traits.rs b/crates/transaction-pool/src/traits.rs
index 0d8f6dbb5..2667143b7 100644
--- a/crates/transaction-pool/src/traits.rs
+++ b/crates/transaction-pool/src/traits.rs
@@ -342,6 +342,12 @@ pub trait TransactionPool: Send + Sync + Clone {
         sender: Address,
     ) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>>;
 
+    /// Returns all pending transactions filtered by predicate
+    fn get_pending_transactions_with_predicate(
+        &self,
+        predicate: impl FnMut(&ValidPoolTransaction<Self::Transaction>) -> bool,
+    ) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>>;
+
     /// Returns all pending transactions sent by a given user
     fn get_pending_transactions_by_sender(
         &self,