add a few more lints (#8574)

Cargo.toml

@@ -163,6 +163,12 @@ string_lit_as_bytes = "warn"
 explicit_into_iter_loop = "warn"
 explicit_iter_loop = "warn"
 type_repetition_in_bounds = "warn"
+manual_string_new = "warn"
+naive_bytecount = "warn"
+needless_bitwise_bool = "warn"
+zero_sized_map_values = "warn"
+single_char_pattern = "warn"
+needless_continue = "warn"
 
 # These are nursery lints which have findings. Allow them for now. Some are not
 # quite mature enough for use in our codebase and some we don't really want.

crates/net/network/src/peers/manager.rs

@@ -883,10 +883,8 @@ impl PeersManager {
                 for peer_id in unbanned_peers {
                     if let Some(peer) = self.peers.get_mut(&peer_id) {
                         peer.unban();
-                    } else {
+                        self.queued_actions.push_back(PeerAction::UnBanPeer { peer_id });
-                        continue
                     }
-                    self.queued_actions.push_back(PeerAction::UnBanPeer { peer_id });
                 }
 
                 // clear the backoff list of expired backoffs, and mark the relevant peers as

crates/tracing/src/lib.rs

@@ -159,7 +159,7 @@ impl Default for LayerInfo {
         Self {
             format: LogFormat::Terminal,
             default_directive: LevelFilter::INFO.to_string(),
-            filters: "".to_string(),
+            filters: String::new(),
             color: Some("always".to_string()),
         }
     }