From 3aaa284a5e43e9fef573b5cb289a09f6f35a9d4d Mon Sep 17 00:00:00 2001 From: Emilia Hane Date: Tue, 20 Aug 2024 01:05:52 -0700 Subject: [PATCH] chore(net): expose pending pool imports bound in cli (#10357) Co-authored-by: Roman Krasiuk --- book/cli/reth/debug/execution.md | 5 +++++ book/cli/reth/debug/in-memory-merkle.md | 5 +++++ book/cli/reth/debug/merkle.md | 5 +++++ book/cli/reth/debug/replay-engine.md | 5 +++++ book/cli/reth/node.md | 5 +++++ book/cli/reth/p2p.md | 5 +++++ book/cli/reth/stage/run.md | 5 +++++ book/cli/reth/stage/unwind.md | 5 +++++ crates/node/core/src/args/network.rs | 9 ++++++++- 9 files changed, 48 insertions(+), 1 deletion(-) diff --git a/book/cli/reth/debug/execution.md b/book/cli/reth/debug/execution.md index fed6f2cb8..c34eb8d7e 100644 --- a/book/cli/reth/debug/execution.md +++ b/book/cli/reth/debug/execution.md @@ -177,6 +177,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/debug/in-memory-merkle.md b/book/cli/reth/debug/in-memory-merkle.md index 044ce7b09..1a089711f 100644 --- a/book/cli/reth/debug/in-memory-merkle.md +++ b/book/cli/reth/debug/in-memory-merkle.md @@ -177,6 +177,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/debug/merkle.md b/book/cli/reth/debug/merkle.md index 7ea6835eb..b996248f6 100644 --- a/book/cli/reth/debug/merkle.md +++ b/book/cli/reth/debug/merkle.md @@ -177,6 +177,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/debug/replay-engine.md b/book/cli/reth/debug/replay-engine.md index aec120e8d..2889487dd 100644 --- a/book/cli/reth/debug/replay-engine.md +++ b/book/cli/reth/debug/replay-engine.md @@ -177,6 +177,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/node.md b/book/cli/reth/node.md index 890ae2976..bf167c6a2 100644 --- a/book/cli/reth/node.md +++ b/book/cli/reth/node.md @@ -169,6 +169,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/p2p.md b/book/cli/reth/p2p.md index 24091f57d..7bda2a578 100644 --- a/book/cli/reth/p2p.md +++ b/book/cli/reth/p2p.md @@ -154,6 +154,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/stage/run.md b/book/cli/reth/stage/run.md index 06bb16a9b..b4f47d0d8 100644 --- a/book/cli/reth/stage/run.md +++ b/book/cli/reth/stage/run.md @@ -220,6 +220,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/book/cli/reth/stage/unwind.md b/book/cli/reth/stage/unwind.md index 1544d271f..930cb8ff7 100644 --- a/book/cli/reth/stage/unwind.md +++ b/book/cli/reth/stage/unwind.md @@ -182,6 +182,11 @@ Networking: --max-inbound-peers Maximum number of inbound requests. default: 30 + --max-pending-imports + Max number of transactions to import concurrently. + + [default: 4096] + --max-seen-tx-history Max number of seen transactions to remember per peer. diff --git a/crates/node/core/src/args/network.rs b/crates/node/core/src/args/network.rs index bcd8fab7c..abec8f915 100644 --- a/crates/node/core/src/args/network.rs +++ b/crates/node/core/src/args/network.rs @@ -12,7 +12,9 @@ use reth_discv5::{ use reth_net_nat::NatResolver; use reth_network::{ transactions::{ - constants::tx_manager::DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER, + constants::tx_manager::{ + DEFAULT_MAX_COUNT_PENDING_POOL_IMPORTS, DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER, + }, TransactionFetcherConfig, TransactionsManagerConfig, DEFAULT_SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESP_ON_PACK_GET_POOLED_TRANSACTIONS_REQ, SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESPONSE, @@ -97,6 +99,10 @@ pub struct NetworkArgs { #[arg(long)] pub max_inbound_peers: Option, + #[arg(long = "max-pending-imports", value_name = "COUNT", default_value_t = DEFAULT_MAX_COUNT_PENDING_POOL_IMPORTS, verbatim_doc_comment)] + /// Max number of transactions to import concurrently. + pub max_pending_pool_imports: usize, + /// Max number of seen transactions to remember per peer. /// /// Default is 320 transaction hashes. @@ -269,6 +275,7 @@ impl Default for NetworkArgs { soft_limit_byte_size_pooled_transactions_response: SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESPONSE, soft_limit_byte_size_pooled_transactions_response_on_pack_request: DEFAULT_SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESP_ON_PACK_GET_POOLED_TRANSACTIONS_REQ, + max_pending_pool_imports: DEFAULT_MAX_COUNT_PENDING_POOL_IMPORTS, max_seen_tx_history: DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER, } }