jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove popped tx from total set (#4599)

Browse Source
This commit is contained in:
Matthias Seitz
2023-09-14 15:40:46 +02:00
committed by GitHub
parent 09b5f1012c
commit 3d564aa393
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/transaction-pool/src/pool/txpool.rs
View File

@ -637,9 +637,17 @@ impl<T: TransactionOrdering> TxPool<T> {
.$limit .$limit
.is_exceeded($this.$pool.len(), $this.$pool.size()) .is_exceeded($this.$pool.len(), $this.$pool.size())
{ {
// pops the worst transaction from the sub-pool
if let Some(tx) = $this.$pool.pop_worst() { if let Some(tx) = $this.$pool.pop_worst() {
let id = tx.transaction_id; let id = tx.transaction_id;
// now that the tx is removed from the sub-pool, we need to remove it also from the total set
$this.all_transactions.remove_transaction(&id);
// record the removed transaction
removed.push(tx); removed.push(tx);
// this might have introduced a nonce gap, so we also discard any descendants
$this.remove_descendants(&id, &mut $removed); $this.remove_descendants(&id, &mut $removed);
} }
} }