jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: add exceeds allowance error message (#14232)

Browse Source
This commit is contained in:
Matthias Seitz
2025-02-05 21:42:27 +01:00
committed by GitHub
parent 8f59efb96a
commit 42a1912224
2 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/rpc/rpc-eth-api/src/helpers/estimate.rs
View File

@ -139,6 +139,16 @@ pub trait EstimateCall: Call {
&mut db,
))
}
Err(err) if err.is_gas_too_low() => {
// This failed because the configured gas cost of the tx was lower than what
// actually consumed by the tx This can happen if the
// request provided fee values manually and the resulting gas cost exceeds the
// sender's allowance, so we return the appropriate error here
return Err(RpcInvalidTransactionError::GasRequiredExceedsAllowance {
gas_limit: tx_env.gas_limit(),
}
.into_eth_err())
}
// Propagate other results (successful or other errors).
ethres => ethres?,
};

17
crates/rpc/rpc-eth-types/src/error/mod.rs
View File

@ -338,6 +338,16 @@ pub enum RpcInvalidTransactionError {
/// Current balance of transaction sender.
balance: U256,
},
/// This is similar to [`Self::InsufficientFunds`] but with a different error message and
/// exists for compatibility reasons.
///
/// This error is used in `eth_estimateCall` when the highest available gas limit, capped with
/// the allowance of the caller is too low: [`Self::GasTooLow`].
#[error("gas required exceeds allowance ({gas_limit})")]
GasRequiredExceedsAllowance {
/// The gas limit the transaction was executed with.
gas_limit: u64,
},
/// Thrown when calculating gas usage
#[error("gas uint64 overflow")]
GasUintOverflow,
@ -448,9 +458,10 @@ impl RpcInvalidTransactionError {
/// Returns the rpc error code for this error.
pub const fn error_code(&self) -> i32 {
match self {
Self::InvalidChainId | Self::GasTooLow | Self::GasTooHigh => {
EthRpcErrorCode::InvalidInput.code()
}
Self::InvalidChainId |
Self::GasTooLow |
Self::GasTooHigh |
Self::GasRequiredExceedsAllowance { .. } => EthRpcErrorCode::InvalidInput.code(),
Self::Revert(_) => EthRpcErrorCode::ExecutionError.code(),
_ => EthRpcErrorCode::TransactionRejected.code(),
}