From 655495d8c322529be0f09d2320cb6f665fc0ce33 Mon Sep 17 00:00:00 2001 From: Thomas Coratger <60488569+tcoratger@users.noreply.github.com> Date: Mon, 26 Aug 2024 04:34:31 -0700 Subject: [PATCH] clippy: add `implicit_clone` clippy lint (#10529) Co-authored-by: Matthias Seitz Co-authored-by: Oliver --- Cargo.toml | 1 + crates/etl/src/lib.rs | 2 +- crates/node/core/src/dirs.rs | 2 +- crates/primitives/src/transaction/mod.rs | 2 +- crates/storage/provider/src/providers/blockchain_provider.rs | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 2a10b59cc..91d9eb3d5 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -216,6 +216,7 @@ unused_rounding = "warn" use_self = "warn" useless_let_if_seq = "warn" zero_sized_map_values = "warn" +implicit_clone = "warn" cloned_instead_of_copied = "warn" option_as_ref_cloned = "warn" diff --git a/crates/etl/src/lib.rs b/crates/etl/src/lib.rs index ebd872d9c..57db6473d 100644 --- a/crates/etl/src/lib.rs +++ b/crates/etl/src/lib.rs @@ -299,7 +299,7 @@ mod tests { let expected = entries[id]; assert_eq!( entry.unwrap(), - (expected.0.encode().to_vec(), expected.1.compress().to_vec()) + (expected.0.encode().to_vec(), expected.1.compress().clone()) ); } diff --git a/crates/node/core/src/dirs.rs b/crates/node/core/src/dirs.rs index a43350c28..5922b6818 100644 --- a/crates/node/core/src/dirs.rs +++ b/crates/node/core/src/dirs.rs @@ -295,7 +295,7 @@ impl ChainPath { pub fn static_files(&self) -> PathBuf { let datadir_args = &self.2; if let Some(static_files_path) = &datadir_args.static_files_path { - static_files_path.to_path_buf() + static_files_path.clone() } else { self.data_dir().join("static_files") } diff --git a/crates/primitives/src/transaction/mod.rs b/crates/primitives/src/transaction/mod.rs index cbc975d39..c1bdcc964 100644 --- a/crates/primitives/src/transaction/mod.rs +++ b/crates/primitives/src/transaction/mod.rs @@ -335,7 +335,7 @@ impl Transaction { match self { Self::Legacy(_) | Self::Eip2930(_) | Self::Eip1559(_) | Self::Eip7702(_) => None, Self::Eip4844(TxEip4844 { blob_versioned_hashes, .. }) => { - Some(blob_versioned_hashes.to_vec()) + Some(blob_versioned_hashes.clone()) } #[cfg(feature = "optimism")] Self::Deposit(_) => None, diff --git a/crates/storage/provider/src/providers/blockchain_provider.rs b/crates/storage/provider/src/providers/blockchain_provider.rs index 176f6292c..65a6a11bf 100644 --- a/crates/storage/provider/src/providers/blockchain_provider.rs +++ b/crates/storage/provider/src/providers/blockchain_provider.rs @@ -1577,7 +1577,7 @@ mod tests { provider.set_safe(safe_block.header.clone()); provider.set_finalized(finalized_block.header.clone()); - Ok((provider, database_blocks.to_vec(), in_memory_blocks.to_vec(), receipts)) + Ok((provider, database_blocks.clone(), in_memory_blocks.clone(), receipts)) } #[allow(clippy::type_complexity)]