jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 19:09:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: return latestValidHash from sidechains (#2725)

Browse Source
This commit is contained in:
Dan Cline
2023-05-18 05:03:51 -04:00
committed by GitHub
parent 20dad4e4fb
commit 65b7702efe
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/consensus/beacon/src/engine/mod.rs
View File

@ -276,12 +276,14 @@ where
return Some(H256::zero()) return Some(H256::zero())
} }
// TODO(mattsse): This could be invoked on new payload which does not make tree canonical, // If this is sent from new payload then the parent hash could be in a side chain, and is
// which would make this inaccurate, e.g. if an invalid payload is received in this // not necessarily canonical
// scenario: FUC (unknown head) -> valid payload -> invalid payload if self.blockchain.header_by_hash(parent_hash).is_some() {
Some(parent_hash)
} else {
self.blockchain.find_canonical_ancestor(parent_hash) self.blockchain.find_canonical_ancestor(parent_hash)
} }
}
/// Loads the header for the given `block_number` from the database. /// Loads the header for the given `block_number` from the database.
fn load_header(&self, block_number: u64) -> Result<Option<Header>, Error> { fn load_header(&self, block_number: u64) -> Result<Option<Header>, Error> {