chore: use DEFAULT_DISCOVERY_PORT constant (#4356)

This commit is contained in:
PatStiles
2023-08-25 03:47:58 -04:00
committed by GitHub
parent 50ba82803d
commit 6d0b00a391
10 changed files with 24 additions and 14 deletions

View File

@ -24,6 +24,7 @@ reth-rlp = { workspace = true, features = [
"ethereum-types",
"smol_str",
] }
reth-discv4 = {path = "../discv4" }
# metrics
reth-metrics.workspace = true

View File

@ -4,6 +4,7 @@
use crate::{
capability::Capability, hello::HelloMessage, p2pstream::ProtocolVersion, EthVersion, Status,
};
use reth_discv4::DEFAULT_DISCOVERY_PORT;
use reth_primitives::{Chain, ForkId, PeerId, H256, U256};
/// Builder for [`Status`](crate::types::Status) messages.
@ -100,7 +101,7 @@ impl HelloBuilder {
client_version: "Ethereum/1.0.0".to_string(),
capabilities: vec![EthVersion::Eth68.into()],
// TODO: default port config
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id: pubkey,
},
}

View File

@ -323,6 +323,7 @@ mod tests {
};
use ethers_core::types::Chain;
use futures::{SinkExt, StreamExt};
use reth_discv4::DEFAULT_DISCOVERY_PORT;
use reth_ecies::{stream::ECIESStream, util::pk2id};
use reth_primitives::{ForkFilter, Head, H256, U256};
use secp256k1::{SecretKey, SECP256K1};
@ -591,7 +592,7 @@ mod tests {
protocol_version: ProtocolVersion::V5,
client_version: "bitcoind/1.0.0".to_string(),
capabilities: vec![Capability::new("eth".into(), EthVersion::Eth67 as usize)],
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id: pk2id(&server_key.public_key(SECP256K1)),
};
@ -619,7 +620,7 @@ mod tests {
protocol_version: ProtocolVersion::V5,
client_version: "bitcoind/1.0.0".to_string(),
capabilities: vec![Capability::new("eth".into(), EthVersion::Eth67 as usize)],
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id: pk2id(&client_key.public_key(SECP256K1)),
};

View File

@ -1,5 +1,6 @@
use crate::{capability::Capability, EthVersion, ProtocolVersion};
use reth_codecs::derive_arbitrary;
use reth_discv4::DEFAULT_DISCOVERY_PORT;
use reth_primitives::{constants::RETH_CLIENT_VERSION, PeerId};
use reth_rlp::{RlpDecodable, RlpEncodable};
@ -99,7 +100,7 @@ impl HelloMessageBuilder {
capabilities: capabilities.unwrap_or_else(|| {
vec![EthVersion::Eth68.into(), EthVersion::Eth67.into(), EthVersion::Eth66.into()]
}),
port: port.unwrap_or(30303),
port: port.unwrap_or(DEFAULT_DISCOVERY_PORT),
id,
}
}
@ -107,6 +108,7 @@ impl HelloMessageBuilder {
#[cfg(test)]
mod tests {
use reth_discv4::DEFAULT_DISCOVERY_PORT;
use reth_ecies::util::pk2id;
use reth_rlp::{Decodable, Encodable, EMPTY_STRING_CODE};
use secp256k1::{SecretKey, SECP256K1};
@ -123,7 +125,7 @@ mod tests {
protocol_version: ProtocolVersion::V5,
client_version: "reth/0.1.0".to_string(),
capabilities: vec![Capability::new("eth".into(), EthVersion::Eth67 as usize)],
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id,
});
@ -143,7 +145,7 @@ mod tests {
protocol_version: ProtocolVersion::V5,
client_version: "reth/0.1.0".to_string(),
capabilities: vec![Capability::new("eth".into(), EthVersion::Eth67 as usize)],
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id,
});
@ -162,7 +164,7 @@ mod tests {
protocol_version: ProtocolVersion::V5,
client_version: "reth/0.1.0".to_string(),
capabilities: vec![Capability::new("eth".into(), EthVersion::Eth67 as usize)],
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id,
});

View File

@ -827,6 +827,7 @@ impl Decodable for ProtocolVersion {
mod tests {
use super::*;
use crate::{DisconnectReason, EthVersion};
use reth_discv4::DEFAULT_DISCOVERY_PORT;
use reth_ecies::util::pk2id;
use secp256k1::{SecretKey, SECP256K1};
use tokio::net::{TcpListener, TcpStream};
@ -839,7 +840,7 @@ mod tests {
protocol_version: ProtocolVersion::V5,
client_version: "bitcoind/1.0.0".to_string(),
capabilities: vec![EthVersion::Eth67.into()],
port: 30303,
port: DEFAULT_DISCOVERY_PORT,
id: pk2id(&server_key.public_key(SECP256K1)),
};
(hello, server_key)