jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: dont include empty revert reason (#5736)

Browse Source
This commit is contained in:
Matthias Seitz
2023-12-12 17:02:49 +01:00
committed by GitHub
parent 829d3ede65
commit 701e37804e
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
crates/revm/revm-inspectors/src/tracing/types.rs
View File

@ -347,7 +347,10 @@ impl CallTraceNode {
// we need to populate error and revert reason // we need to populate error and revert reason
if !self.trace.success { if !self.trace.success {
call_frame.revert_reason = decode_revert_reason(self.trace.output.as_ref()); // decode the revert reason, but don't include it if it's empty
call_frame.revert_reason = decode_revert_reason(self.trace.output.as_ref())
.filter(|reason| !reason.is_empty());
// Note: the call tracer mimics parity's trace transaction and geth maps errors to parity style error messages, <https://github.com/ethereum/go-ethereum/blob/34d507215951fb3f4a5983b65e127577989a6db8/eth/tracers/native/call_flat.go#L39-L55> // Note: the call tracer mimics parity's trace transaction and geth maps errors to parity style error messages, <https://github.com/ethereum/go-ethereum/blob/34d507215951fb3f4a5983b65e127577989a6db8/eth/tracers/native/call_flat.go#L39-L55>
call_frame.error = self.trace.as_error_msg(TraceStyle::Parity); call_frame.error = self.trace.as_error_msg(TraceStyle::Parity);
} }
@ -676,3 +679,14 @@ impl AsRef<[u8]> for RecordedMemory {
self.as_bytes() self.as_bytes()
} }
} }
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn decode_empty_revert() {
let reason = decode_revert_reason("".as_bytes());
assert_eq!(reason, Some("".to_string()));
}
}