jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug hashes buffered for busy peer gave false-positive on eth68 check (#6427)

Browse Source
This commit is contained in:
Emilia Hane
2024-02-05 23:39:45 +01:00
committed by GitHub
parent 5b847cba4f
commit 75132dabba
4 changed files with 243 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
crates/net/network/src/transactions/validation.rs
View File

@ -237,7 +237,7 @@ impl FilterAnnouncement for EthAnnouncementFilter {
network=%Self,
"empty eth68 announcement"
);
return (FilterOutcome::ReportPeer, HashMap::new())
return (FilterOutcome::ReportPeer, ValidAnnouncementData::empty_eth68())
}
let mut should_report_peer = false;
@ -284,7 +284,7 @@ impl FilterAnnouncement for EthAnnouncementFilter {
(
if should_report_peer { FilterOutcome::ReportPeer } else { FilterOutcome::Ok },
deduped_data,
ValidAnnouncementData::new_eth68(deduped_data),
)
}
@ -306,7 +306,7 @@ impl FilterAnnouncement for EthAnnouncementFilter {
network=%Self,
"empty eth66 announcement"
);
return (FilterOutcome::ReportPeer, HashMap::new())
return (FilterOutcome::ReportPeer, ValidAnnouncementData::empty_eth66())
}
// 2. checks if announcement is spam packed with duplicate hashes
@ -324,7 +324,7 @@ impl FilterAnnouncement for EthAnnouncementFilter {
} else {
FilterOutcome::Ok
},
deduped_data,
ValidAnnouncementData::new_eth66(deduped_data),
)
}
}
@ -380,7 +380,7 @@ mod test {
let mut expected_data = HashMap::new();
expected_data.insert(hashes[1], Some((types[1], sizes[1])));
assert_eq!(expected_data, data,)
assert_eq!(expected_data, data.into_data())
}
#[test]
@ -416,7 +416,7 @@ mod test {
let mut expected_data = HashMap::new();
expected_data.insert(hashes[2], Some((types[2], sizes[2])));
assert_eq!(expected_data, data,)
assert_eq!(expected_data, data.into_data())
}
#[test]
@ -456,7 +456,7 @@ mod test {
expected_data.insert(hashes[3], Some((types[3], sizes[3])));
expected_data.insert(hashes[0], Some((types[0], sizes[0])));
assert_eq!(expected_data, data,)
assert_eq!(expected_data, data.into_data())
}
#[test]
@ -500,7 +500,7 @@ mod test {
expected_data.insert(hashes[1], None);
expected_data.insert(hashes[0], None);
assert_eq!(expected_data, data)
assert_eq!(expected_data, data.into_data())
}
#[test]