jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: add note about eip-4844 broadcast (#4570)

Browse Source
This commit is contained in:
Matthias Seitz
2023-09-12 21:42:37 +02:00
committed by GitHub
parent e2270cd71c
commit 76d56cb7ba
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/net/network/src/transactions.rs
View File

@ -20,7 +20,7 @@ use reth_metrics::common::mpsc::UnboundedMeteredReceiver;
use reth_network_api::{Peers, ReputationChangeKind}; use reth_network_api::{Peers, ReputationChangeKind};
use reth_primitives::{ use reth_primitives::{
FromRecoveredPooledTransaction, IntoRecoveredTransaction, PeerId, PooledTransactionsElement, FromRecoveredPooledTransaction, IntoRecoveredTransaction, PeerId, PooledTransactionsElement,
TransactionSigned, TxHash, TxType, H256, TransactionSigned, TxHash, H256,
}; };
use reth_rlp::Encodable; use reth_rlp::Encodable;
use reth_transaction_pool::{ use reth_transaction_pool::{
@ -244,7 +244,7 @@ where
/// The message for new pooled hashes depends on the negotiated version of the stream. /// The message for new pooled hashes depends on the negotiated version of the stream.
/// See [NewPooledTransactionHashes](NewPooledTransactionHashes) /// See [NewPooledTransactionHashes](NewPooledTransactionHashes)
/// ///
/// TODO add note that this never broadcasts full 4844 transactions /// Note: EIP-4844 are disallowed from being broadcast in full and are only ever sent as hashes, see also <https://eips.ethereum.org/EIPS/eip-4844#networking>.
fn propagate_transactions( fn propagate_transactions(
&mut self, &mut self,
to_propagate: Vec<PropagateTransaction>, to_propagate: Vec<PropagateTransaction>,
@ -276,7 +276,7 @@ where
// via `GetPooledTransactions`. // via `GetPooledTransactions`.
// //
// From: <https://eips.ethereum.org/EIPS/eip-4844#networking> // From: <https://eips.ethereum.org/EIPS/eip-4844#networking>
if tx.tx_type() != TxType::EIP4844 { if !tx.transaction.is_eip4844() {
full_transactions.push(tx); full_transactions.push(tx);
} }
} }
@ -672,10 +672,6 @@ impl PropagateTransaction {
self.transaction.hash() self.transaction.hash()
} }
fn tx_type(&self) -> TxType {
self.transaction.tx_type()
}
fn new(transaction: Arc<TransactionSigned>) -> Self { fn new(transaction: Arc<TransactionSigned>) -> Self {
Self { size: transaction.length(), transaction } Self { size: transaction.length(), transaction }
} }