Move reputation types from reth-network-api to reth-network-types (#9914)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

crates/net/network-api/Cargo.toml

@@ -16,6 +16,7 @@ workspace = true
 reth-eth-wire.workspace = true
 alloy-rpc-types-admin.workspace = true
 reth-network-peers.workspace = true
+reth-network-types.workspace = true
 
 # ethereum
 alloy-primitives.workspace = true

crates/net/network-api/src/lib.rs

@@ -13,20 +13,20 @@
 )]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
+use std::{future::Future, net::SocketAddr, sync::Arc, time::Instant};
+
 pub use alloy_rpc_types_admin::EthProtocolInfo;
 pub use error::NetworkError;
-pub use reputation::{Reputation, ReputationChangeKind};
+
 use reth_eth_wire::{capability::Capabilities, DisconnectReason, EthVersion, Status};
 use reth_network_peers::NodeRecord;
-use std::{future::Future, net::SocketAddr, sync::Arc, time::Instant};
+pub use reth_network_types::{Reputation, ReputationChangeKind};
 
 /// The `PeerId` type.
 pub type PeerId = alloy_primitives::B512;
 
 /// Network Error
 pub mod error;
-/// Reputation score
-pub mod reputation;
 
 /// Implementation of network traits for that does nothing.
 pub mod noop;

crates/net/network-api/src/reputation.rs

@@ -1,52 +0,0 @@
-/// The type that tracks the reputation score.
-pub type Reputation = i32;
-
-/// Various kinds of reputation changes.
-#[derive(Debug, Copy, Clone, PartialEq, Eq)]
-pub enum ReputationChangeKind {
-    /// Received an unspecific bad message from the peer
-    BadMessage,
-    /// Peer sent a bad block.
-    ///
-    /// Note: this will we only used in pre-merge, pow consensus, since after no more block announcements are sent via devp2p: [EIP-3675](https://eips.ethereum.org/EIPS/eip-3675#devp2p)
-    BadBlock,
-    /// Peer sent a bad transaction message. E.g. Transactions which weren't recoverable.
-    BadTransactions,
-    /// Peer sent a bad announcement message, e.g. invalid transaction type for the configured
-    /// network.
-    BadAnnouncement,
-    /// Peer sent a message that included a hash or transaction that we already received from the
-    /// peer.
-    ///
-    /// According to the [Eth spec](https://github.com/ethereum/devp2p/blob/master/caps/eth.md):
-    ///
-    /// > A node should never send a transaction back to a peer that it can determine already knows
-    /// > of it (either because it was previously sent or because it was informed from this peer
-    /// > originally). This is usually achieved by remembering a set of transaction hashes recently
-    /// > relayed by the peer.
-    AlreadySeenTransaction,
-    /// Peer failed to respond in time.
-    Timeout,
-    /// Peer does not adhere to network protocol rules.
-    BadProtocol,
-    /// Failed to establish a connection to the peer.
-    FailedToConnect,
-    /// Connection dropped by peer.
-    Dropped,
-    /// Reset the reputation to the default value.
-    Reset,
-    /// Apply a reputation change by value
-    Other(Reputation),
-}
-
-impl ReputationChangeKind {
-    /// Returns true if the reputation change is a [`ReputationChangeKind::Reset`].
-    pub const fn is_reset(&self) -> bool {
-        matches!(self, Self::Reset)
-    }
-
-    /// Returns true if the reputation change is [`ReputationChangeKind::Dropped`].
-    pub const fn is_dropped(&self) -> bool {
-        matches!(self, Self::Dropped)
-    }
-}