From 8df9efd6ca745886a349d350011a354de56b0bef Mon Sep 17 00:00:00 2001 From: nk_ysg Date: Sat, 24 Aug 2024 15:37:56 +0800 Subject: [PATCH] docs: fix broken link in review.md (#10480) --- docs/design/database.md | 2 +- docs/design/review.md | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/design/database.md b/docs/design/database.md index 06ac63a05..cf2a6c8fc 100644 --- a/docs/design/database.md +++ b/docs/design/database.md @@ -14,7 +14,7 @@ - We implemented that trait for the following encoding formats: - [Ethereum-specific Compact Encoding](https://github.com/paradigmxyz/reth/blob/0d9b9a392d4196793736522f3fc2ac804991b45d/crates/codecs/derive/src/compact/mod.rs): A lot of Ethereum datatypes have unnecessary zeros when serialized, or optional (e.g. on empty hashes) which would be nice not to pay in storage costs. - [Erigon](https://github.com/ledgerwatch/erigon/blob/12ee33a492f5d240458822d052820d9998653a63/docs/programmers_guide/db_walkthrough.MD) achieves that by having a `bitfield` set on Table "PlainState which adds a bitfield to Accounts. - - Akula expanded it for other tables and datatypes manually. It also saved some more space by storing the length of certain types (U256, u64) using the [`modular_bitfield`](https://docs.rs/modular-bitfield/latest/modular_bitfield/) crate, which compacts this information. + - [Akula](https://github.com/akula-bft/akula/) expanded it for other tables and datatypes manually. It also saved some more space by storing the length of certain types (U256, u64) using the [`modular_bitfield`](https://docs.rs/modular-bitfield/latest/modular_bitfield/) crate, which compacts this information. - We generalized it for all types, by writing a derive macro that autogenerates code for implementing the trait. It, also generates the interfaces required for fuzzing using ToB/test-fuzz: - [Scale Encoding](https://github.com/paritytech/parity-scale-codec) - [Postcard Encoding](https://github.com/jamesmunns/postcard) diff --git a/docs/design/review.md b/docs/design/review.md index 693c991a7..2bd4973a9 100644 --- a/docs/design/review.md +++ b/docs/design/review.md @@ -19,7 +19,6 @@ This document contains some of our research in how other codebases designed vari ## Database * [Erigon's DB walkthrough](https://github.com/ledgerwatch/erigon/blob/12ee33a492f5d240458822d052820d9998653a63/docs/programmers_guide/db_walkthrough.MD) contains an overview. They made the most noticeable improvements on storage reduction. -* [Erigon Videos](https://youtu.be/QqL72qWhF-g) explain new proposals in improving in future versions and take some insights from it. (example: CumulativeTxCount, EliasFano) * [Gio's erigon-db table macros](https://github.com/gio256/erigon-db) + [Akula's macros](https://github.com/akula-bft/akula/blob/74b172ee1d2d2a4f04ce057b5a76679c1b83df9c/src/kv/tables.rs#L61). ## Header Downloaders