jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce recommended soft limit for get pooled requests (#4210)

Browse Source
This commit is contained in:
Matthias Seitz
2023-08-15 18:36:39 +02:00
committed by GitHub
parent 7f83d0a05a
commit 981873dca9
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
crates/net/network/src/transactions.rs
View File

@ -47,6 +47,11 @@ const NEW_POOLED_TRANSACTION_HASHES_SOFT_LIMIT: usize = 4096;
/// The target size for the message of full transactions. /// The target size for the message of full transactions.
const MAX_FULL_TRANSACTIONS_PACKET_SIZE: usize = 100 * 1024; const MAX_FULL_TRANSACTIONS_PACKET_SIZE: usize = 100 * 1024;
/// Recommended soft limit for the number of hashes in a GetPooledTransactions message (8kb)
///
/// <https://github.com/ethereum/devp2p/blob/master/caps/eth.md#newpooledtransactionhashes-0x08>
const GET_POOLED_TRANSACTION_SOFT_LIMIT_NUM_HASHES: usize = 256;
/// The future for inserting a function into the pool /// The future for inserting a function into the pool
pub type PoolImportFuture = Pin<Box<dyn Future<Output = PoolResult<TxHash>> + Send + 'static>>; pub type PoolImportFuture = Pin<Box<dyn Future<Output = PoolResult<TxHash>> + Send + 'static>>;
@ -332,6 +337,10 @@ where
return return
} }
// enforce recommended soft limit, however the peer may enforce an arbitrary limit on
// the response (2MB)
hashes.truncate(GET_POOLED_TRANSACTION_SOFT_LIMIT_NUM_HASHES);
// request the missing transactions // request the missing transactions
let (response, rx) = oneshot::channel(); let (response, rx) = oneshot::channel();
let req = PeerRequest::GetPooledTransactions { let req = PeerRequest::GetPooledTransactions {