lints: move top-level lints to [workspace.lints] manifest table (#5935)

Cargo.toml

@@ -66,6 +66,14 @@ default-members = ["bin/reth"]
 # https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html
 resolver = "2"
 
+[workspace.lints]
+rust.missing_debug_implementations = "warn"
+rust.missing_docs = "warn"
+rust.unreachable_pub = "warn"
+rustdoc.all = "warn"
+rust.unused_must_use = "deny"
+rust.rust_2018_idioms = "deny"
+
 [workspace.package]
 version = "0.1.0-alpha.13"
 edition = "2021"

bin/reth/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 description = "Reth node implementation"
 default-run = "reth"
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
     # Used for diagrams in docs

bin/reth/build.rs

@@ -1,3 +1,5 @@
+#![allow(missing_docs)]
+
 use std::error::Error;
 use vergen::EmitBuilder;
 

bin/reth/src/lib.rs

@@ -24,8 +24,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![allow(missing_debug_implementations)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod args;

bin/reth/src/main.rs

@@ -1,4 +1,5 @@
 // We use jemalloc for performance reasons
+#![allow(missing_docs)]
 #[cfg(all(feature = "jemalloc", unix))]
 #[global_allocator]
 static ALLOC: jemallocator::Jemalloc = jemallocator::Jemalloc;

bin/reth/src/optimism.rs

@@ -1,3 +1,4 @@
+#![allow(missing_docs, rustdoc::missing_crate_level_docs)]
 // We use jemalloc for performance reasons
 #[cfg(all(feature = "jemalloc", unix))]
 #[global_allocator]

crates/blockchain-tree/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
     # Used for diagrams in docs

crates/blockchain-tree/src/lib.rs

@@ -15,8 +15,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod blockchain_tree;

crates/config/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-network.workspace = true

crates/config/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod config;

crates/consensus/auto-seal/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "A consensus impl for local testing purposes"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-beacon-consensus.workspace = true

crates/consensus/auto-seal/src/lib.rs

@@ -12,8 +12,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use reth_beacon_consensus::BeaconEngineMessage;
@@ -42,7 +40,7 @@ use std::{
     time::{SystemTime, UNIX_EPOCH},
 };
 use tokio::sync::{mpsc::UnboundedSender, RwLock, RwLockReadGuard, RwLockWriteGuard};
-use tracing::{trace, warn};
+use tracing::trace;
 
 mod client;
 mod mode;

crates/consensus/auto-seal/tests/it/auto_mine.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! auto-mine consensus integration test
 
 use clap::Parser;

crates/consensus/beacon/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-beacon-consensus-core.workspace = true

crates/consensus/beacon/src/lib.rs

@@ -5,14 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unused_crate_dependencies,
-    unreachable_pub,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub use reth_beacon_consensus_core::BeaconConsensus;

crates/consensus/common/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/consensus/common/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Collection of consensus validation methods.

crates/ethereum-forks/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Ethereum fork types used in reth."
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-codecs.workspace = true

crates/ethereum-forks/src/lib.rs

@@ -11,8 +11,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms, unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod forkid;

crates/interfaces/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 reth-primitives.workspace = true
 reth-nippy-jar.workspace = true

crates/interfaces/src/lib.rs

@@ -9,14 +9,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unused_crate_dependencies,
-    unreachable_pub,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![warn(unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Consensus traits.

crates/metrics/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "reth metrics utilities"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-metrics-derive.workspace = true

crates/metrics/metrics-derive/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 proc-macro = true
 

crates/metrics/metrics-derive/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use proc_macro::TokenStream;

crates/metrics/src/lib.rs

@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Metrics derive macro.

crates/net/common/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Types shared across network code"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/net/common/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod ban_list;

crates/net/discv4/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Ethereum network discovery"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/net/discv4/src/lib.rs

@@ -21,8 +21,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms, unreachable_pub, unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use crate::{
@@ -64,7 +62,7 @@ use tokio::{
     time::Interval,
 };
 use tokio_stream::{wrappers::ReceiverStream, Stream, StreamExt};
-use tracing::{debug, trace, warn};
+use tracing::{debug, trace};
 
 pub mod error;
 pub mod proto;

crates/net/dns/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Support for EIP-1459 Node Discovery via DNS"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/net/dns/src/lib.rs

@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub use crate::resolver::{DnsResolver, MapResolver, Resolver};
@@ -47,7 +45,7 @@ use tokio_stream::{
     wrappers::{ReceiverStream, UnboundedReceiverStream},
     Stream, StreamExt,
 };
-use tracing::{debug, trace, warn};
+use tracing::{debug, trace};
 
 mod config;
 mod error;

crates/net/downloaders/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Implementations of various block downloaders"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-interfaces.workspace = true

crates/net/downloaders/src/lib.rs

@@ -9,8 +9,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// The collection of algorithms for downloading block bodies.

crates/net/ecies/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 reth-primitives.workspace = true
 reth-net-common.workspace = true

crates/net/ecies/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod algorithm;

crates/net/eth-wire/Cargo.toml

@@ -8,6 +8,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-codecs.workspace = true

crates/net/eth-wire/src/lib.rs

@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod builder;

crates/net/nat/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Helpers for working around NAT"
 
+[lints]
+workspace = true
+
 [dependencies]
 
 # nat

crates/net/nat/src/lib.rs

@@ -9,8 +9,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use igd::aio::search_gateway;

crates/net/network-api/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Network interfaces"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/net/network-api/src/lib.rs

@@ -11,8 +11,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use async_trait::async_trait;

crates/net/network/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Ethereum network support"
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
     # Used for diagrams in docs

crates/net/network/benches/bench.rs

@@ -1,3 +1,4 @@
+#![allow(missing_docs)]
 use criterion::*;
 use futures::StreamExt;
 use pprof::criterion::{Output, PProfProfiler};

crates/net/network/src/lib.rs

@@ -106,8 +106,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, rustdoc::all)] // TODO(danipopes): unreachable_pub
-#![deny(unused_must_use, rust_2018_idioms)]
+#![allow(unreachable_pub)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[cfg(any(test, feature = "test-utils"))]

crates/net/network/tests/it/clique/clique_middleware.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! Helper extension traits for working with clique providers.
 
 use async_trait::async_trait;

crates/net/network/tests/it/clique/geth.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! Helper struct for working with a clique geth instance.
 
 use enr::k256::ecdsa::SigningKey;

crates/net/network/tests/it/clique/mod.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 pub mod clique_middleware;
 mod geth;
 

crates/net/network/tests/it/multiplex.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! Testing gossiping of transactions.
 
 use crate::multiplex::proto::{PingPongProtoMessage, PingPongProtoMessageKind};

crates/net/network/tests/it/requests.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! Tests for eth related requests
 
 use rand::Rng;

crates/payload/basic/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "A basic payload builder for reth that uses the txpool API to build payloads."
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/payload/basic/src/lib.rs

@@ -5,14 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unused_crate_dependencies,
-    unreachable_pub,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use alloy_rlp::Encodable;

crates/payload/builder/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "reth payload builder"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/payload/builder/src/lib.rs

@@ -97,8 +97,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod database;

crates/payload/ethereum/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "A basic ethereum payload builder for reth that uses the txpool API to build payloads."
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/payload/ethereum/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[cfg(not(feature = "optimism"))]

crates/payload/optimism/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "A payload builder for op-reth that builds optimistic payloads."
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/payload/optimism/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[cfg(feature = "optimism")]

crates/payload/validator/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Payload validation support"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/payload/validator/src/lib.rs

@@ -5,14 +5,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unreachable_pub,
-    unused_crate_dependencies,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![warn(unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use reth_primitives::{ChainSpec, SealedBlock};

crates/primitives/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 rust-version.workspace = true
 description = "Commonly used types in reth."
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-codecs.workspace = true

crates/primitives/benches/nibbles.rs

@@ -1,3 +1,4 @@
+#![allow(missing_docs)]
 use criterion::{criterion_group, criterion_main, Criterion};
 use proptest::{prelude::*, strategy::ValueTree};
 use reth_primitives::trie::Nibbles;

crates/primitives/benches/recover_ecdsa_crit.rs

@@ -1,3 +1,4 @@
+#![allow(missing_docs)]
 use alloy_rlp::Decodable;
 use criterion::{criterion_group, criterion_main, Criterion};
 use pprof::criterion::{Output, PProfProfiler};

crates/primitives/benches/trie_root.rs

@@ -1,3 +1,4 @@
+#![allow(missing_docs, unreachable_pub)]
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use proptest::{
     prelude::*,

crates/primitives/src/lib.rs

@@ -12,8 +12,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod account;

crates/prune/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Pruning implementation"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/prune/src/lib.rs

@@ -5,8 +5,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, unreachable_pub, rustdoc::all)] // TODO(danipopes): missing_docs
-#![deny(unused_must_use, rust_2018_idioms)]
+#![allow(missing_docs)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod builder;

crates/revm/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "reth specific revm utilities"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/revm/revm-inspectors/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "revm inspector implementations used by reth"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-rpc-types.workspace = true

crates/revm/revm-inspectors/src/lib.rs

@@ -10,8 +10,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms, unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// An inspector implementation for an EIP2930 Accesslist

crates/revm/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// Contains glue code for integrating reth database into revm's [Database].

crates/rpc/ipc/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "IPC support for reth"
 
+[lints]
+workspace = true
+
 [dependencies]
 
 # async/net

crates/rpc/ipc/src/lib.rs

@@ -9,8 +9,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[cfg(unix)]

crates/rpc/rpc-api/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Reth RPC interfaces"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/rpc/rpc-api/src/lib.rs

@@ -11,8 +11,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod admin;

crates/rpc/rpc-builder/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Helpers for configuring RPC"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/rpc/rpc-builder/src/lib.rs

@@ -132,8 +132,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use std::{

crates/rpc/rpc-builder/tests/it/http.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 //! Standalone http tests
 
 use crate::utils::{launch_http, launch_http_ws, launch_ws};

crates/rpc/rpc-builder/tests/it/serde.rs

@@ -21,7 +21,7 @@ impl ToRpcParams for RawRpcParams {
 async fn test_eth_balance_serde() {
     let handle = launch_http(vec![RethRpcModule::Eth]).await;
     let s = r#"{"jsonrpc":"2.0","id":1,"method":"eth_getBalance","params":["0xaa00000000000000000000000000000000000000","0x898753d8fdd8d92c1907ca21e68c7970abd290c647a202091181deec3f30a0b2"]}"#;
-    let req: Request = serde_json::from_str(s).unwrap();
+    let req: Request<'_> = serde_json::from_str(s).unwrap();
     let client = handle.http_client().unwrap();
 
     let params = RawRpcParams(RawValue::from_string(req.params.unwrap().to_string()).unwrap());

crates/rpc/rpc-engine-api/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Implementation of Engine API"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/rpc/rpc-engine-api/src/lib.rs

@@ -6,8 +6,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 /// The Engine API implementation.

crates/rpc/rpc-testing-util/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Reth RPC testing helpers"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/rpc/rpc-testing-util/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod debug;

crates/rpc/rpc-types-compat/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Compatibility layer for reth-primitives and ethereum RPC types"
 
+[lints]
+workspace = true
+
 [dependencies]
 reth-primitives.workspace = true
 reth-rpc-types.workspace = true

crates/rpc/rpc-types-compat/src/lib.rs

@@ -7,8 +7,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 pub mod block;

crates/rpc/rpc-types/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Reth RPC types"
 
+[lints]
+workspace = true
+
 [dependencies]
 # ethereum
 alloy-rlp = { workspace = true, features = ["arrayvec", "derive"] }

crates/rpc/rpc-types/src/lib.rs

@@ -7,8 +7,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod admin;

crates/rpc/rpc/Cargo.toml

@@ -7,6 +7,10 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 description = "Reth RPC implementation"
+
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-interfaces.workspace = true

crates/rpc/rpc/src/lib.rs

@@ -22,8 +22,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod admin;

crates/snapshot/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Snapshotting implementation"
 
+[lints]
+workspace = true
+
 [dependencies]
 # reth
 reth-primitives.workspace = true

crates/snapshot/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod error;

crates/stages/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 description = "Staged syncing primitives used in reth."
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
     # Used for diagrams in docs

crates/stages/benches/criterion.rs

@@ -1,3 +1,4 @@
+#![allow(missing_docs, elided_lifetimes_in_paths)]
 use criterion::{
     async_executor::FuturesExecutor, criterion_group, criterion_main, measurement::WallTime,
     BenchmarkGroup, Criterion,

crates/stages/benches/setup/account_hashing.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 use super::{constants, StageRange};
 use reth_db::{
     cursor::DbCursorRO, database::Database, tables, transaction::DbTx, DatabaseError as DbError,

crates/stages/benches/setup/constants.rs

@@ -1 +1,2 @@
+#![allow(unreachable_pub)]
 pub const ACCOUNT_HASHING_DB: &str = "ACCOUNT_HASHING_DB";

crates/stages/benches/setup/mod.rs

@@ -1,3 +1,4 @@
+#![allow(unreachable_pub)]
 use itertools::concat;
 use reth_db::{
     cursor::DbCursorRO,

crates/stages/src/lib.rs

@@ -64,8 +64,6 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(missing_debug_implementations, missing_docs, unreachable_pub, rustdoc::all)]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod error;

crates/storage/codecs/Cargo.toml

@@ -7,6 +7,9 @@ license.workspace = true
 homepage.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 codecs-derive = { path = "./derive", default-features = false }
 

crates/storage/codecs/derive/Cargo.toml

@@ -8,6 +8,9 @@ homepage.workspace = true
 repository.workspace = true
 readme = "../README.md"
 
+[lints]
+workspace = true
+
 [package.metadata.cargo-udeps.ignore]
 normal = [
   # Used in proc macros

crates/storage/codecs/derive/src/lib.rs

@@ -5,7 +5,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![allow(unreachable_pub, missing_docs)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 use proc_macro::{self, TokenStream, TokenTree};

crates/storage/codecs/src/lib.rs

@@ -5,14 +5,7 @@
     html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
     issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
 )]
-#![warn(
-    missing_debug_implementations,
-    missing_docs,
-    unused_crate_dependencies,
-    unreachable_pub,
-    rustdoc::all
-)]
-#![deny(unused_must_use, rust_2018_idioms)]
+#![warn(unused_crate_dependencies)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 #![cfg_attr(not(feature = "std"), no_std)]