From a40b79e1932ddb18ee2ba0e4de9f1494ccf146c9 Mon Sep 17 00:00:00 2001 From: Dan Cline <6798349+Rjected@users.noreply.github.com> Date: Wed, 17 May 2023 16:32:56 -0400 Subject: [PATCH] fix: set sync state at startup to idle (#2722) --- crates/consensus/beacon/src/engine/mod.rs | 5 ----- crates/net/network/src/network.rs | 2 +- crates/net/network/tests/it/startup.rs | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/crates/consensus/beacon/src/engine/mod.rs b/crates/consensus/beacon/src/engine/mod.rs index ecee3fe38..d82668d97 100644 --- a/crates/consensus/beacon/src/engine/mod.rs +++ b/crates/consensus/beacon/src/engine/mod.rs @@ -700,11 +700,6 @@ where block_hash, )); - // Update the network sync state to `Idle`. - // Handles the edge case where the pipeline is never triggered, because we - // are sufficiently synced. - self.sync_state_updater.update_sync_state(SyncState::Idle); - PayloadStatusEnum::Valid } BlockStatus::Accepted => { diff --git a/crates/net/network/src/network.rs b/crates/net/network/src/network.rs index f4c286617..44337e155 100644 --- a/crates/net/network/src/network.rs +++ b/crates/net/network/src/network.rs @@ -54,7 +54,7 @@ impl NetworkHandle { peers, network_mode, bandwidth_meter, - is_syncing: Arc::new(AtomicBool::new(true)), + is_syncing: Arc::new(AtomicBool::new(false)), chain_id, }; Self { inner: Arc::new(inner) } diff --git a/crates/net/network/tests/it/startup.rs b/crates/net/network/tests/it/startup.rs index 7366d3242..4994a7365 100644 --- a/crates/net/network/tests/it/startup.rs +++ b/crates/net/network/tests/it/startup.rs @@ -28,7 +28,7 @@ async fn test_is_default_syncing() { .listener_port(0) .build(NoopProvider::default()); let network = NetworkManager::new(config).await.unwrap(); - assert!(network.handle().is_syncing()); + assert!(!network.handle().is_syncing()); } #[tokio::test(flavor = "multi_thread")]