jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(txpool): use Vec in validate_all (#5044)

Browse Source
This commit is contained in:
Dan Cline
2023-10-17 11:52:43 -04:00
committed by GitHub
parent 5efadd86ee
commit b399e5d552
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
crates/transaction-pool/src/lib.rs
View File

@ -148,10 +148,7 @@ use crate::pool::PoolInner;
use aquamarine as _;
use reth_primitives::{Address, BlobTransactionSidecar, PooledTransactionsElement, TxHash, U256};
use reth_provider::StateProviderFactory;
use std::{
collections::{HashMap, HashSet},
sync::Arc,
};
use std::{collections::HashSet, sync::Arc};
use tokio::sync::mpsc::Receiver;
use tracing::{instrument, trace};
@ -230,19 +227,21 @@ where
}
/// Returns future that validates all transaction in the given iterator.
///
/// This returns the validated transactions in the iterator's order.
async fn validate_all(
&self,
origin: TransactionOrigin,
transactions: impl IntoIterator<Item = V::Transaction>,
) -> PoolResult<HashMap<TxHash, TransactionValidationOutcome<V::Transaction>>> {
let outcome = futures_util::future::join_all(
) -> PoolResult<Vec<(TxHash, TransactionValidationOutcome<V::Transaction>)>> {
let outcomes = futures_util::future::join_all(
transactions.into_iter().map(|tx| self.validate(origin, tx)),
)
.await
.into_iter()
.collect::<HashMap<_, _>>();
.collect();
Ok(outcome)
Ok(outcomes)
}
/// Validates the given transaction
@ -348,7 +347,8 @@ where
) -> PoolResult<Vec<PoolResult<TxHash>>> {
let validated = self.validate_all(origin, transactions).await?;
let transactions = self.pool.add_transactions(origin, validated.into_values());
let transactions =
self.pool.add_transactions(origin, validated.into_iter().map(|(_, tx)| tx));
Ok(transactions)
}