jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 19:09:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(rlp): add comment on 0x80 decoding (#312)

Browse Source 
* add comment on 0x80 decoding

 * decode 0x80 into zero explicitly

* add explicit 0x80 decoding for ethereum types
This commit is contained in:
Dan Cline
2022-12-01 21:27:33 -05:00
committed by GitHub
parent a3f9e28d71
commit bc3702ec42
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/common/rlp/src/decode.rs
View File

@ -185,6 +185,12 @@ macro_rules! decode_integer {
if buf.remaining() < h.payload_length {
return Err(DecodeError::InputTooShort)
}
// In the case of 0x80, the Header will be decoded, leaving h.payload_length to be
// zero.
// 0x80 is the canonical encoding of 0, so we return 0 here.
if h.payload_length == 0 {
return Ok(<$t>::from(0u8))
}
let v = <$t>::from_be_bytes(
static_left_pad(&buf[..h.payload_length]).ok_or(DecodeError::LeadingZero)?,
);
@ -252,6 +258,12 @@ mod ethereum_types_support {
if buf.remaining() < h.payload_length {
return Err(DecodeError::InputTooShort)
}
// In the case of 0x80, the Header will be decoded, leaving h.payload_length to
// be zero.
// 0x80 is the canonical encoding of 0, so we return 0 here.
if h.payload_length == 0 {
return Ok(<$t>::from(0u8))
}
let n = <$t>::from_big_endian(
&static_left_pad::<$n_bytes>(&buf[..h.payload_length])
.ok_or(DecodeError::LeadingZero)?,