Revert "chore: enable tx inserts via p2p" (#2252)

This commit is contained in:
Georgios Konstantopoulos
2023-04-14 18:18:13 -04:00
committed by GitHub
parent 6be4be6b2a
commit c67c944a1f
2 changed files with 9 additions and 7 deletions

View File

@ -528,15 +528,14 @@ where
this.on_good_import(hash);
}
Err(err) => {
// if we're syncing and the transaction is bad we ignore it, otherwise we
// penalize the peer that sent the bad transaction with the assumption that the
// peer should have known that this transaction is bad. (e.g. consensus rules)
if err.is_bad_transaction() && !this.network.is_syncing() {
if err.is_bad_transaction() {
trace!(target: "net::tx", ?err, "Bad transaction import");
this.on_bad_import(*err.hash());
continue
// TODO disabled until properly tested
// this.on_bad_import(*err.hash());
this.on_good_import(*err.hash());
} else {
this.on_good_import(*err.hash());
}
this.on_good_import(*err.hash());
}
}
}