jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use cached encoded length (#4577)

Browse Source
This commit is contained in:
Matthias Seitz
2023-09-14 00:04:02 +02:00
committed by GitHub
parent c531c1b60a
commit c831d30d2d
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
crates/net/network/src/transactions.rs
View File

@ -22,7 +22,6 @@ use reth_primitives::{
FromRecoveredPooledTransaction, IntoRecoveredTransaction, PeerId, PooledTransactionsElement,
TransactionSigned, TxHash, H256,
};
use reth_rlp::Encodable;
use reth_transaction_pool::{
error::PoolResult, GetPooledTransactionLimit, PoolTransaction, PropagateKind,
PropagatedTransactions, TransactionPool, ValidPoolTransaction,
@ -205,7 +204,7 @@ where
}
}
/// Invoked when a new transaction is pending.
/// Invoked when a new transaction is pending in the local pool.
///
/// When new transactions appear in the pool, we propagate them to the network using the
/// `Transactions` and `NewPooledTransactionHashes` messages. The Transactions message relays
@ -224,15 +223,10 @@ where
trace!(target: "net::tx", "Start propagating transactions");
// This fetches all transaction from the pool, including the blob transactions, which are
// only ever sent as hashes.
let propagated = self.propagate_transactions(
self.pool
.get_all(hashes)
.into_iter()
.map(|tx| {
let tx = Arc::new(tx.transaction.to_recovered_transaction().into_signed());
PropagateTransaction::new(tx)
})
.collect(),
self.pool.get_all(hashes).into_iter().map(PropagateTransaction::new).collect(),
);
// notify pool so events get fired
@ -672,8 +666,11 @@ impl PropagateTransaction {
self.transaction.hash()
}
fn new(transaction: Arc<TransactionSigned>) -> Self {
Self { size: transaction.length(), transaction }
/// Create a new instance from a pooled transaction
fn new<T: PoolTransaction>(tx: Arc<ValidPoolTransaction<T>>) -> Self {
let size = tx.encoded_length;
let transaction = Arc::new(tx.transaction.to_recovered_transaction().into_signed());
Self { size, transaction }
}
}