From cb123084bf6d22f5b6b8a185697f8333a20525ae Mon Sep 17 00:00:00 2001 From: Oliver Date: Fri, 11 Oct 2024 04:53:19 +0200 Subject: [PATCH] docs: `LoadFee::eip1559_fees` returns base fee, not max fee per gas (#11652) --- crates/rpc/rpc-eth-api/src/helpers/fee.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/crates/rpc/rpc-eth-api/src/helpers/fee.rs b/crates/rpc/rpc-eth-api/src/helpers/fee.rs index b6dcef470..52ccabebf 100644 --- a/crates/rpc/rpc-eth-api/src/helpers/fee.rs +++ b/crates/rpc/rpc-eth-api/src/helpers/fee.rs @@ -284,15 +284,15 @@ pub trait LoadFee: LoadBlock { /// Returns the EIP-1559 fees if they are set, otherwise fetches a suggested gas price for /// EIP-1559 transactions. /// - /// Returns (`max_fee`, `priority_fee`) + /// Returns (`base_fee`, `priority_fee`) fn eip1559_fees( &self, - max_fee_per_gas: Option, + base_fee: Option, max_priority_fee_per_gas: Option, ) -> impl Future> + Send { async move { - let max_fee_per_gas = match max_fee_per_gas { - Some(max_fee_per_gas) => max_fee_per_gas, + let base_fee = match base_fee { + Some(base_fee) => base_fee, None => { // fetch pending base fee let base_fee = self @@ -311,7 +311,7 @@ pub trait LoadFee: LoadBlock { Some(max_priority_fee_per_gas) => max_priority_fee_per_gas, None => self.suggested_priority_fee().await?, }; - Ok((max_fee_per_gas, max_priority_fee_per_gas)) + Ok((base_fee, max_priority_fee_per_gas)) } }