jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(bin): make experimental engine default (#11612)

Browse Source
This commit is contained in:
Alexey Shekhirin
2024-10-10 16:04:31 +01:00
committed by GitHub
parent 58bac0ee30
commit d027b7b938
2 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
bin/reth/src/main.rs
View File

@ -14,15 +14,24 @@ use reth_node_builder::{
}; };
use reth_node_ethereum::{node::EthereumAddOns, EthereumNode}; use reth_node_ethereum::{node::EthereumAddOns, EthereumNode};
use reth_provider::providers::BlockchainProvider2; use reth_provider::providers::BlockchainProvider2;
use reth_tracing::tracing::warn;
use tracing::info;
/// Parameters for configuring the engine /// Parameters for configuring the engine
#[derive(Debug, Clone, Args, PartialEq, Eq)] #[derive(Debug, Clone, Args, PartialEq, Eq)]
#[command(next_help_heading = "Engine")] #[command(next_help_heading = "Engine")]
pub struct EngineArgs { pub struct EngineArgs {
/// Enable the engine2 experimental features on reth binary /// Enable the experimental engine features on reth binary
///
/// DEPRECATED: experimental engine is default now, use --engine.legacy to enable the legacy
/// functionality
#[arg(long = "engine.experimental", default_value = "false")] #[arg(long = "engine.experimental", default_value = "false")]
pub experimental: bool, pub experimental: bool,
/// Enable the legacy engine on reth binary
#[arg(long = "engine.legacy", default_value = "false")]
pub legacy: bool,
/// Configure persistence threshold for engine experimental. /// Configure persistence threshold for engine experimental.
#[arg(long = "engine.persistence-threshold", requires = "experimental", default_value_t = DEFAULT_PERSISTENCE_THRESHOLD)] #[arg(long = "engine.persistence-threshold", requires = "experimental", default_value_t = DEFAULT_PERSISTENCE_THRESHOLD)]
pub persistence_threshold: u64, pub persistence_threshold: u64,
@ -36,6 +45,7 @@ impl Default for EngineArgs {
fn default() -> Self { fn default() -> Self {
Self { Self {
experimental: false, experimental: false,
legacy: false,
persistence_threshold: DEFAULT_PERSISTENCE_THRESHOLD, persistence_threshold: DEFAULT_PERSISTENCE_THRESHOLD,
memory_block_buffer_target: DEFAULT_MEMORY_BLOCK_BUFFER_TARGET, memory_block_buffer_target: DEFAULT_MEMORY_BLOCK_BUFFER_TARGET,
} }
@ -52,9 +62,13 @@ fn main() {
if let Err(err) = if let Err(err) =
Cli::<EthereumChainSpecParser, EngineArgs>::parse().run(|builder, engine_args| async move { Cli::<EthereumChainSpecParser, EngineArgs>::parse().run(|builder, engine_args| async move {
let enable_engine2 = engine_args.experimental; if engine_args.experimental {
match enable_engine2 { warn!(target: "reth::cli", "Experimental engine is default now, and the --engine.experimental flag is deprecated. To enable the legacy functionality, use --engine.legacy.");
true => { }
let use_legacy_engine = engine_args.legacy;
match use_legacy_engine {
false => {
let engine_tree_config = TreeConfig::default() let engine_tree_config = TreeConfig::default()
.with_persistence_threshold(engine_args.persistence_threshold) .with_persistence_threshold(engine_args.persistence_threshold)
.with_memory_block_buffer_target(engine_args.memory_block_buffer_target); .with_memory_block_buffer_target(engine_args.memory_block_buffer_target);
@ -73,7 +87,8 @@ fn main() {
.await?; .await?;
handle.node_exit_future.await handle.node_exit_future.await
} }
false => { true => {
info!(target: "reth::cli", "Running with legacy engine");
let handle = builder.launch_node(EthereumNode::default()).await?; let handle = builder.launch_node(EthereumNode::default()).await?;
handle.node_exit_future.await handle.node_exit_future.await
} }

7
book/cli/reth/node.md vendored
View File

@ -666,7 +666,12 @@ Pruning:
Engine: Engine:
--engine.experimental --engine.experimental
Enable the engine2 experimental features on reth binary Enable the experimental engine features on reth binary
DEPRECATED: experimental engine is default now, use --engine.legacy to enable the legacy functionality
--engine.legacy
Enable the legacy engine on reth binary
--engine.persistence-threshold <PERSISTENCE_THRESHOLD> --engine.persistence-threshold <PERSISTENCE_THRESHOLD>
Configure persistence threshold for engine experimental Configure persistence threshold for engine experimental