diff --git a/crates/blockchain-tree/src/blockchain_tree.rs b/crates/blockchain-tree/src/blockchain_tree.rs index fd9128bcd..965dc7cfa 100644 --- a/crates/blockchain-tree/src/blockchain_tree.rs +++ b/crates/blockchain-tree/src/blockchain_tree.rs @@ -888,7 +888,7 @@ mod tests { let externals = setup_externals(vec![exec2.clone(), exec1.clone(), exec2, exec1]); // last finalized block would be number 9. - setup_genesis(externals.db.clone(), genesis.clone()); + setup_genesis(externals.db.clone(), genesis); // make tree let config = BlockchainTreeConfig::new(1, 2, 3, 2); diff --git a/crates/net/downloaders/src/bodies/task.rs b/crates/net/downloaders/src/bodies/task.rs index c54893f61..f7b60bf62 100644 --- a/crates/net/downloaders/src/bodies/task.rs +++ b/crates/net/downloaders/src/bodies/task.rs @@ -186,6 +186,7 @@ mod tests { } #[tokio::test(flavor = "multi_thread")] + #[allow(clippy::reversed_empty_ranges)] async fn set_download_range_error_returned() { reth_tracing::init_test_tracing(); diff --git a/crates/net/network/src/peers/manager.rs b/crates/net/network/src/peers/manager.rs index 16eae888d..5dd333ff2 100644 --- a/crates/net/network/src/peers/manager.rs +++ b/crates/net/network/src/peers/manager.rs @@ -369,7 +369,7 @@ impl PeersManager { /// Gracefully disconnected a pending session pub(crate) fn on_pending_session_gracefully_closed(&mut self, peer_id: &PeerId) { - if let Some(mut peer) = self.peers.get_mut(peer_id) { + if let Some(peer) = self.peers.get_mut(peer_id) { peer.state = PeerConnectionState::Idle; } else { return @@ -466,7 +466,7 @@ impl PeersManager { } else { let mut backoff_until = None; - if let Some(mut peer) = self.peers.get_mut(peer_id) { + if let Some(peer) = self.peers.get_mut(peer_id) { if let Some(kind) = err.should_backoff() { // Increment peer.backoff_counter if kind.is_severe() { diff --git a/crates/rpc/rpc/src/eth/filter.rs b/crates/rpc/rpc/src/eth/filter.rs index e3a52447d..2a6470aea 100644 --- a/crates/rpc/rpc/src/eth/filter.rs +++ b/crates/rpc/rpc/src/eth/filter.rs @@ -77,7 +77,7 @@ where let (start_block, kind) = { let mut filters = self.inner.active_filters.inner.lock().await; - let mut filter = filters.get_mut(&id).ok_or(FilterError::FilterNotFound(id))?; + let filter = filters.get_mut(&id).ok_or(FilterError::FilterNotFound(id))?; // update filter // we fetch all changes from [filter.block..best_block], so we advance the filter's diff --git a/crates/stages/src/pipeline/set.rs b/crates/stages/src/pipeline/set.rs index 902b3bfa9..78cb8d2b6 100644 --- a/crates/stages/src/pipeline/set.rs +++ b/crates/stages/src/pipeline/set.rs @@ -163,7 +163,7 @@ where /// /// Panics if the stage is not in this set. pub fn enable(mut self, stage_id: StageId) -> Self { - let mut entry = + let entry = self.stages.get_mut(&stage_id).expect("Cannot enable a stage that is not in the set."); entry.enabled = true; self @@ -180,7 +180,7 @@ where /// /// Panics if the stage is not in this set. pub fn disable(mut self, stage_id: StageId) -> Self { - let mut entry = + let entry = self.stages.get_mut(&stage_id).expect("Cannot disable a stage that is not in the set."); entry.enabled = false; self diff --git a/crates/trie/benches/prefix_set.rs b/crates/trie/benches/prefix_set.rs index 2bf5c0646..a79f3e9f1 100644 --- a/crates/trie/benches/prefix_set.rs +++ b/crates/trie/benches/prefix_set.rs @@ -101,7 +101,7 @@ fn generate_test_data(size: usize) -> (Vec, Vec, Vec) { let expected = input .iter() - .map(|prefix| preload.iter().any(|key| key.has_prefix(&prefix))) + .map(|prefix| preload.iter().any(|key| key.has_prefix(prefix))) .collect::>(); (preload, input, expected) } @@ -204,7 +204,7 @@ mod implementations { self.sorted = true; } - let prefix = prefix.into(); + let prefix = prefix; while self.index > 0 && self.keys[self.index] > prefix { self.index -= 1; @@ -227,7 +227,7 @@ mod implementations { fn insert(&mut self, nibbles: Nibbles) { self.sorted = false; - self.keys.push(nibbles.into()); + self.keys.push(nibbles); } }