fix: update block interval properly (#11546)

This commit is contained in:
Matthias Seitz
2024-10-16 23:59:58 +02:00
committed by GitHub
parent 82862fabd7
commit d2ca8f3a2b
2 changed files with 33 additions and 21 deletions

View File

@ -14,6 +14,9 @@ use std::{
const EXTENSION: &str = "toml";
/// The default prune block interval
pub const DEFAULT_BLOCK_INTERVAL: usize = 5;
/// Configuration for the reth node.
#[derive(Debug, Clone, Default, Deserialize, PartialEq, Eq, Serialize)]
#[serde(default)]
@ -383,7 +386,7 @@ pub struct PruneConfig {
impl Default for PruneConfig {
fn default() -> Self {
Self { block_interval: 5, segments: PruneModes::none() }
Self { block_interval: DEFAULT_BLOCK_INTERVAL, segments: PruneModes::none() }
}
}
@ -397,27 +400,33 @@ impl PruneConfig {
/// if the corresponding value in this config is not set.
pub fn merge(&mut self, other: Option<Self>) {
let Some(other) = other else { return };
let Self {
block_interval,
segments:
PruneModes {
sender_recovery,
transaction_lookup,
receipts,
account_history,
storage_history,
receipts_log_filter,
},
} = other;
// Merge block_interval
if self.block_interval == 0 {
self.block_interval = other.block_interval;
// Merge block_interval, only update if it's the default interval
if self.block_interval == DEFAULT_BLOCK_INTERVAL {
self.block_interval = block_interval;
}
// Merge the various segment prune modes
self.segments.sender_recovery =
self.segments.sender_recovery.or(other.segments.sender_recovery);
self.segments.transaction_lookup =
self.segments.transaction_lookup.or(other.segments.transaction_lookup);
self.segments.receipts = self.segments.receipts.or(other.segments.receipts);
self.segments.account_history =
self.segments.account_history.or(other.segments.account_history);
self.segments.storage_history =
self.segments.storage_history.or(other.segments.storage_history);
self.segments.sender_recovery = self.segments.sender_recovery.or(sender_recovery);
self.segments.transaction_lookup = self.segments.transaction_lookup.or(transaction_lookup);
self.segments.receipts = self.segments.receipts.or(receipts);
self.segments.account_history = self.segments.account_history.or(account_history);
self.segments.storage_history = self.segments.storage_history.or(storage_history);
if self.segments.receipts_log_filter.0.is_empty() &&
!other.segments.receipts_log_filter.0.is_empty()
{
self.segments.receipts_log_filter = other.segments.receipts_log_filter;
if self.segments.receipts_log_filter.0.is_empty() && !receipts_log_filter.0.is_empty() {
self.segments.receipts_log_filter = receipts_log_filter;
}
}
}
@ -961,7 +970,7 @@ receipts = 'full'
// Check that the configuration has been merged. Any configuration present in config1
// should not be overwritten by config2
assert_eq!(config1.block_interval, 5);
assert_eq!(config1.block_interval, 10);
assert_eq!(config1.segments.sender_recovery, Some(PruneMode::Full));
assert_eq!(config1.segments.transaction_lookup, Some(PruneMode::Full));
assert_eq!(config1.segments.receipts, Some(PruneMode::Distance(1000)));