add empty_line_after_doc_comments and remove option_if_let_else (#8539)

Cargo.toml

@@ -154,6 +154,7 @@ unused_rounding = "warn"
 useless_let_if_seq = "warn"
 use_self = "warn"
 missing_const_for_fn = "warn"
+empty_line_after_doc_comments = "warn"
 
 # These are nursery lints which have findings. Allow them for now. Some are not
 # quite mature enough for use in our codebase and some we don't really want.
@@ -162,13 +163,11 @@ as_ptr_cast_mut = "allow"
 cognitive_complexity = "allow"
 collection_is_never_read = "allow"
 debug_assert_with_mut_call = "allow"
-empty_line_after_doc_comments = "allow"
 fallible_impl_from = "allow"
 future_not_send = "allow"
 iter_on_single_items = "allow"
 needless_collect = "allow"
 non_send_fields_in_send_ty = "allow"
-option_if_let_else = "allow"
 redundant_pub_crate = "allow"
 significant_drop_in_scrutinee = "allow"
 significant_drop_tightening = "allow"

crates/node-core/src/args/types.rs

@@ -3,7 +3,6 @@
 use std::{fmt, num::ParseIntError, str::FromStr};
 
 /// A macro that generates types that maps "0" to "None" when parsing CLI arguments.
-
 macro_rules! zero_as_none {
     ($type_name:ident, $inner_type:ty) => {
         #[derive(Debug, Clone, Copy, PartialEq, Eq)]

crates/rpc/ipc/src/server/mod.rs

@@ -48,8 +48,8 @@ mod ipc;
 mod rpc_service;
 
 /// Ipc Server implementation
-
-// This is an adapted `jsonrpsee` Server, but for `Ipc` connections.
+///
+/// This is an adapted `jsonrpsee` Server, but for `Ipc` connections.
 pub struct IpcServer<HttpMiddleware = Identity, RpcMiddleware = Identity> {
     /// The endpoint we listen for incoming transactions
     endpoint: String,

crates/rpc/rpc-builder/src/lib.rs

@@ -1518,7 +1518,7 @@ pub struct RpcServerConfig {
     jwt_secret: Option<JwtSecret>,
 }
 
-/// === impl RpcServerConfig ===
+// === impl RpcServerConfig ===
 
 impl RpcServerConfig {
     /// Creates a new config with only http set

crates/storage/provider/src/providers/database/provider.rs

@@ -1641,8 +1641,7 @@ impl<TX: DbTx> TransactionsProviderExt for DatabaseProvider<TX> {
     }
 }
 
-/// Calculates the hash of the given transaction
-
+// Calculates the hash of the given transaction
 impl<TX: DbTx> TransactionsProvider for DatabaseProvider<TX> {
     fn transaction_id(&self, tx_hash: TxHash) -> ProviderResult<Option<TxNumber>> {
         Ok(self.tx.get::<tables::TransactionHashNumbers>(tx_hash)?)