jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure transfer gas estimation succeeds (#7485)

Browse Source
This commit is contained in:
Matthias Seitz
2024-04-08 14:21:26 +02:00
committed by GitHub
parent 8c89d9ca85
commit f4f039de01
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
crates/rpc/rpc/src/eth/api/call.rs
View File

@ -225,15 +225,18 @@ where
if let Ok(code) = db.db.account_code(to) {
let no_code_callee = code.map(|code| code.is_empty()).unwrap_or(true);
if no_code_callee {
// simple transfer, check if caller has sufficient funds
let available_funds =
db.basic_ref(env.tx.caller)?.map(|acc| acc.balance).unwrap_or_default();
if env.tx.value > available_funds {
return Err(
RpcInvalidTransactionError::InsufficientFundsForTransfer.into()
)
// If the tx is a simple transfer (call to an account with no code) we can
// shortcircuit But simply returning
// `MIN_TRANSACTION_GAS` is dangerous because there might be additional
// field combos that bump the price up, so we try executing the function
// with the minimum gas limit to make sure.
let mut env = env.clone();
env.tx.gas_limit = MIN_TRANSACTION_GAS;
if let Ok((res, _)) = self.transact(&mut db, env) {
if res.result.is_success() {
return Ok(U256::from(MIN_TRANSACTION_GAS))
}
}
return Ok(U256::from(MIN_TRANSACTION_GAS))
}
}
}