From fb981cec4d14b356da894b0f6692414cac8f292e Mon Sep 17 00:00:00 2001
From: Matthias Seitz <matthias.seitz@outlook.de>
Date: Thu, 16 Nov 2023 15:13:24 +0100
Subject: [PATCH] chore: move criterion and pprof to workspace (#5461)

---
 Cargo.lock                           | 4 ++--
 Cargo.toml                           | 3 ++-
 crates/primitives/Cargo.toml         | 4 ++--
 crates/stages/Cargo.toml             | 4 ++--
 crates/storage/db/Cargo.toml         | 4 ++--
 crates/storage/libmdbx-rs/Cargo.toml | 4 ++--
 crates/transaction-pool/Cargo.toml   | 2 +-
 crates/trie/Cargo.toml               | 2 +-
 8 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 934b8fb06..e1f81c2c2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5058,9 +5058,9 @@ checksum = "439ee305def115ba05938db6eb1644ff94165c5ab5e9420d1c1bcedbba909391"
 
 [[package]]
 name = "pprof"
-version = "0.12.1"
+version = "0.13.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "978385d59daf9269189d052ca8a84c1acfd0715c0599a5d5188d4acc078ca46a"
+checksum = "ef5c97c51bd34c7e742402e216abdeb44d415fbe6ae41d56b114723e953711cb"
 dependencies = [
  "backtrace",
  "cfg-if",
diff --git a/Cargo.toml b/Cargo.toml
index d003e1e51..d0bbf106e 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -214,7 +214,8 @@ toml = "0.8"
 arbitrary = "1.1"
 assert_matches = "1.5.0"
 tempfile = "3.8"
-
+criterion = "0.5"
+pprof = "0.13"
 proptest = "1.0"
 proptest-derive = "0.4"
 serial_test = "2"
diff --git a/crates/primitives/Cargo.toml b/crates/primitives/Cargo.toml
index 9bd00d6ee..4a9cfcedc 100644
--- a/crates/primitives/Cargo.toml
+++ b/crates/primitives/Cargo.toml
@@ -81,8 +81,8 @@ hash-db = "~0.15"
 # necessary so we don't hit a "undeclared 'std'":
 # https://github.com/paradigmxyz/reth/pull/177#discussion_r1021172198
 secp256k1.workspace = true
-criterion = "0.5"
-pprof = { version = "0.12", features = ["flamegraph", "frame-pointer", "criterion"] }
+criterion.workspace = true
+pprof = { workspace = true, features = ["flamegraph", "frame-pointer", "criterion"] }
 
 [features]
 default = ["c-kzg"]
diff --git a/crates/stages/Cargo.toml b/crates/stages/Cargo.toml
index 08e04fdaf..6da02ad00 100644
--- a/crates/stages/Cargo.toml
+++ b/crates/stages/Cargo.toml
@@ -70,8 +70,8 @@ rand.workspace = true
 paste = "1.0"
 
 # Stage benchmarks
-pprof = { version = "0.12", features = ["flamegraph", "frame-pointer", "criterion"] }
-criterion = { version = "0.5", features = ["async_futures"] }
+pprof = { workspace = true, features = ["flamegraph", "frame-pointer", "criterion"] }
+criterion = { workspace = true, features = ["async_futures"] }
 
 # io
 serde_json.workspace = true
diff --git a/crates/storage/db/Cargo.toml b/crates/storage/db/Cargo.toml
index c6103d732..60e13ad2f 100644
--- a/crates/storage/db/Cargo.toml
+++ b/crates/storage/db/Cargo.toml
@@ -62,8 +62,8 @@ reth-interfaces.workspace = true
 tempfile.workspace = true
 test-fuzz = "4"
 
-pprof = { version = "0.12", features = ["flamegraph", "frame-pointer", "criterion"] }
-criterion = "0.5"
+pprof = { workspace = true, features = ["flamegraph", "frame-pointer", "criterion"] }
+criterion.workspace = true
 iai = "0.1.1"
 tokio = { workspace = true, features = ["full"] }
 
diff --git a/crates/storage/libmdbx-rs/Cargo.toml b/crates/storage/libmdbx-rs/Cargo.toml
index 094724f58..dc65f34fa 100644
--- a/crates/storage/libmdbx-rs/Cargo.toml
+++ b/crates/storage/libmdbx-rs/Cargo.toml
@@ -29,8 +29,8 @@ default = []
 return-borrowed = []
 
 [dev-dependencies]
-pprof = { version = "0.12", features = ["flamegraph", "frame-pointer", "criterion"] }
-criterion = "0.5"
+pprof = { workspace = true, features = ["flamegraph", "frame-pointer", "criterion"] }
+criterion.workspace = true
 rand.workspace = true
 rand_xorshift = "0.3"
 tempfile.workspace = true
diff --git a/crates/transaction-pool/Cargo.toml b/crates/transaction-pool/Cargo.toml
index f654fe9a6..93548f83f 100644
--- a/crates/transaction-pool/Cargo.toml
+++ b/crates/transaction-pool/Cargo.toml
@@ -56,7 +56,7 @@ reth-provider = { workspace = true, features = ["test-utils"] }
 paste = "1.0"
 rand = "0.8"
 proptest.workspace = true
-criterion = "0.5"
+criterion.workspace = true
 assert_matches.workspace = true
 tempfile.workspace = true
 
diff --git a/crates/trie/Cargo.toml b/crates/trie/Cargo.toml
index f4cd70f21..1aaf2be53 100644
--- a/crates/trie/Cargo.toml
+++ b/crates/trie/Cargo.toml
@@ -46,7 +46,7 @@ tokio-stream.workspace = true
 once_cell.workspace = true
 serde_json.workspace = true
 pretty_assertions = "1.3.0"
-criterion = "0.5"
+criterion.workspace = true
 
 [features]
 test-utils = ["triehash"]