jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle closed download channel in headers downloader (#1369)

Browse Source
This commit is contained in:
Matthias Seitz
2023-02-15 12:34:07 +01:00
committed by GitHub
parent 022bf6342d
commit 5bf41610d7
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
crates/net/downloaders/src/headers/reverse_headers.rs
View File

@ -620,7 +620,7 @@ where
// The downloader boundaries (local head and sync target) have to be set in order
// to start downloading data.
if this.local_head.is_none() || this.sync_target.is_none() {
tracing::trace!(
trace!(
target: "downloaders::headers",
head=?this.local_block_number(),
sync_target=?this.sync_target,
@ -635,6 +635,11 @@ where
match req.poll_unpin(cx) {
Poll::Ready(outcome) => {
if let Err(err) = this.on_sync_target_outcome(outcome) {
if err.is_channel_closed() {
// download channel closed which means the network was dropped
return Poll::Ready(None)
}
this.penalize_peer(err.peer_id, &err.error);
this.metrics.increment_errors(&err.error);
this.sync_target_request =
@ -664,6 +669,10 @@ where
this.metrics.in_flight_requests.decrement(1.);
// handle response
if let Err(err) = this.on_headers_outcome(outcome) {
if err.is_channel_closed() {
// download channel closed which means the network was dropped
return Poll::Ready(None)
}
this.on_headers_error(err);
}
}
@ -803,6 +812,16 @@ struct HeadersResponseError {
error: DownloadError,
}
impl HeadersResponseError {
/// Returns true if the error was caused by a closed channel to the network.
fn is_channel_closed(&self) -> bool {
if let DownloadError::RequestError(ref err) = self.error {
return err.is_channel_closed()
}
false
}
}
/// The block to which we want to close the gap: (local head...sync target]
#[derive(Debug, Default)]
struct SyncTargetBlock {