jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: dont upscale concurrent request for lower peer count (#2661)

Browse Source
This commit is contained in:
Matthias Seitz
2023-05-14 03:02:51 +02:00
committed by GitHub
parent 0a71d6fa8b
commit 9fe84bfd96
1 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
crates/net/downloaders/src/bodies/bodies.rs
View File

@ -26,15 +26,6 @@ use std::{
task::{Context, Poll},
};
/// The multiplier for the number of connected peers.
/// This might be used as an upper bound for determining the
/// number of concurrent requests.
///
/// The multiplier is needed to optimistically increase the number
/// of concurrent requests, since we are expecting to connect to more peers
/// in the near future.
const CONCURRENCY_PEER_MULTIPLIER: usize = 4;
/// The scope for headers downloader metrics.
pub const BODIES_DOWNLOADER_SCOPE: &str = "downloaders.bodies";
@ -171,17 +162,14 @@ where
fn concurrent_request_limit(&self) -> usize {
let num_peers = self.client.num_connected_peers();
// we try to keep more requests than available peers active so that there's always a
// followup request available for a peer
let dynamic_target = num_peers * CONCURRENCY_PEER_MULTIPLIER;
let max_dynamic = dynamic_target.max(*self.concurrent_requests_range.start());
let max_requests = num_peers.max(*self.concurrent_requests_range.start());
// If only a few peers are connected we keep it low
// if we're only connected to a few peers, we keep it low
if num_peers < *self.concurrent_requests_range.start() {
return max_dynamic
return max_requests
}
max_dynamic.min(*self.concurrent_requests_range.end())
max_requests.min(*self.concurrent_requests_range.end())
}
/// Returns true if the number of buffered blocks is lower than the configured maximum