Remove redundant clones (#4485)

This commit is contained in:
JosepBove
2023-09-05 10:30:18 +02:00
committed by GitHub
parent 1ec4d462a2
commit b2750e0e9b
4 changed files with 4 additions and 4 deletions

View File

@ -58,7 +58,7 @@ impl Command {
debug!(target: "reth::cli", chain=%self.chain.chain, genesis=?self.chain.genesis_hash(), "Initializing genesis");
init_genesis(db.clone(), self.chain.clone())?;
let factory = ProviderFactory::new(&db, self.chain.clone());
let factory = ProviderFactory::new(&db, self.chain);
let mut provider = factory.provider_rw()?;
let best_block = provider.best_block_number()?;
let best_header = provider

View File

@ -564,7 +564,7 @@ where
// FCU resulted in a fatal error from which we can't recover
let err = err.clone();
let _ = tx.send(Err(error));
return OnForkchoiceUpdateOutcome::Fatal(err.clone())
return OnForkchoiceUpdateOutcome::Fatal(err)
}
}
let _ = tx.send(Err(error));

View File

@ -591,7 +591,7 @@ impl<DB: Database> Pruner<DB> {
.collect::<Vec<_>>();
// Number of transactions retrieved from the database should match the tx range count
let tx_count = tx_range.clone().count();
let tx_count = tx_range.count();
if hashes.len() != tx_count {
return Err(PrunerError::InconsistentData(
"Unexpected number of transaction hashes retrieved by transaction number range",

View File

@ -685,7 +685,7 @@ impl<'this, TX: DbTxMut<'this> + DbTx<'this>> DatabaseProvider<'this, TX> {
mut delete_callback: impl FnMut(TableRow<T>),
) -> std::result::Result<(usize, bool), DatabaseError> {
let mut cursor = self.tx.cursor_write::<T>()?;
let mut walker = cursor.walk_range(keys.clone())?;
let mut walker = cursor.walk_range(keys)?;
let mut deleted = 0;
while let Some(row) = walker.next().transpose()? {