jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: be less strict about what's a bad tx (#2268)

Browse Source
This commit is contained in:
Matthias Seitz
2023-04-15 12:44:21 +02:00
committed by GitHub
parent ec097fabf1
commit b45182ae2c
1 changed files with 38 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
crates/transaction-pool/src/error.rs
View File

@ -50,7 +50,7 @@ impl PoolError {
}
/// Returns `true` if the error was caused by a transaction that is considered bad in the
/// context of the transaction pool.
/// context of the transaction pool and warrants peer penalization.
///
/// Not all error variants are caused by the incorrect composition of the transaction (See also
/// [InvalidPoolTransactionError]) and can be caused by the current state of the transaction
@ -85,9 +85,9 @@ impl PoolError {
// valid tx but dropped due to size constraints
false
}
PoolError::InvalidTransaction(_, _) => {
PoolError::InvalidTransaction(_, err) => {
// transaction rejected because it violates constraints
true
err.is_bad_transaction()
}
PoolError::Other(_, _) => {
// internal error unrelated to the transaction
@ -122,3 +122,38 @@ pub enum InvalidPoolTransactionError {
#[error("transaction underpriced")]
Underpriced,
}
// === impl InvalidPoolTransactionError ===
impl InvalidPoolTransactionError {
/// Returns `true` if the error was caused by a transaction that is considered bad in the
/// context of the transaction pool and warrants peer penalization.
///
/// See [PoolError::is_bad_transaction].
#[inline]
fn is_bad_transaction(&self) -> bool {
match self {
InvalidPoolTransactionError::Consensus(err) => {
// transaction considered invalid by the consensus rules
// We do not consider the following errors to be erroneous transactions, since they
// depend on dynamic environmental conditions and should not be assumed to have been
// intentionally caused by the sender
match err {
InvalidTransactionError::InsufficientFunds { .. } |
InvalidTransactionError::NonceNotConsistent => {
// transaction could just have arrived late/early
false
}
_ => true,
}
}
InvalidPoolTransactionError::ExceedsGasLimit(_, _) => true,
InvalidPoolTransactionError::ExceedsMaxInitCodeSize(_, _) => true,
InvalidPoolTransactionError::OversizedData(_, _) => true,
InvalidPoolTransactionError::Underpriced => {
// local setting
false
}
}
}
}