jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(engine): track elapsed on fork block added (#10710)

Browse Source
This commit is contained in:
Roman Krasiuk
2024-09-05 17:25:38 +02:00
committed by GitHub
parent ba3fc6a9a9
commit c267c1caf7
4 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/consensus/beacon/src/engine/event.rs
View File

@ -8,14 +8,14 @@ use std::{sync::Arc, time::Duration};
pub enum BeaconConsensusEngineEvent {
/// The fork choice state was updated, and the current fork choice status
ForkchoiceUpdated(ForkchoiceState, ForkchoiceStatus),
/// A block was added to the fork chain.
ForkBlockAdded(Arc<SealedBlock>, Duration),
/// A block was added to the canonical chain, and the elapsed time validating the block
CanonicalBlockAdded(Arc<SealedBlock>, Duration),
/// A canonical chain was committed, and the elapsed time committing the data
CanonicalChainCommitted(Box<SealedHeader>, Duration),
/// The consensus engine is involved in live sync, and has specific progress
LiveSyncProgress(ConsensusEngineLiveSyncProgress),
/// A block was added to the fork chain.
ForkBlockAdded(Arc<SealedBlock>),
}
impl BeaconConsensusEngineEvent {

2
crates/consensus/beacon/src/engine/mod.rs
View File

@ -1244,7 +1244,7 @@ where
let event = if attachment.is_canonical() {
BeaconConsensusEngineEvent::CanonicalBlockAdded(block, elapsed)
} else {
BeaconConsensusEngineEvent::ForkBlockAdded(block)
BeaconConsensusEngineEvent::ForkBlockAdded(block, elapsed)
};
self.event_sender.notify(event);
PayloadStatusEnum::Valid

6
crates/engine/tree/src/tree/mod.rs
View File

@ -2112,10 +2112,11 @@ where
let finalized = self.state.forkchoice_state_tracker.sync_target_finalized();
// emit insert event
let elapsed = start.elapsed();
let engine_event = if self.is_fork(block_hash, finalized)? {
BeaconConsensusEngineEvent::ForkBlockAdded(sealed_block)
BeaconConsensusEngineEvent::ForkBlockAdded(sealed_block, elapsed)
} else {
BeaconConsensusEngineEvent::CanonicalBlockAdded(sealed_block, start.elapsed())
BeaconConsensusEngineEvent::CanonicalBlockAdded(sealed_block, elapsed)
};
self.emit_event(EngineApiEvent::BeaconConsensus(engine_event));
@ -2665,6 +2666,7 @@ mod tests {
match event {
EngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::ForkBlockAdded(
block,
_,
)) => {
assert!(block.hash() == expected_hash);
}

4
crates/node/events/src/node.rs
View File

@ -275,8 +275,8 @@ impl NodeState {
info!(number=head.number, hash=?head.hash(), ?elapsed, "Canonical chain committed");
}
BeaconConsensusEngineEvent::ForkBlockAdded(block) => {
info!(number=block.number, hash=?block.hash(), "Block added to fork chain");
BeaconConsensusEngineEvent::ForkBlockAdded(block, elapsed) => {
info!(number=block.number, hash=?block.hash(), ?elapsed, "Block added to fork chain");
}
}
}