jleony/nanoreth
1
0
Fork 0
mirror of https://github.com/hl-archive-node/nanoreth.git synced 2025-12-06 10:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: LoadFee::eip1559_fees returns base fee, not max fee per gas (#11652)

Browse Source
This commit is contained in:
Oliver
2024-10-11 04:53:19 +02:00
committed by GitHub
parent 1ba631ba95
commit cb123084bf
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/rpc/rpc-eth-api/src/helpers/fee.rs
View File

@ -284,15 +284,15 @@ pub trait LoadFee: LoadBlock {
/// Returns the EIP-1559 fees if they are set, otherwise fetches a suggested gas price for
/// EIP-1559 transactions.
///
/// Returns (`max_fee`, `priority_fee`)
/// Returns (`base_fee`, `priority_fee`)
fn eip1559_fees(
&self,
max_fee_per_gas: Option<U256>,
base_fee: Option<U256>,
max_priority_fee_per_gas: Option<U256>,
) -> impl Future<Output = Result<(U256, U256), Self::Error>> + Send {
async move {
let max_fee_per_gas = match max_fee_per_gas {
Some(max_fee_per_gas) => max_fee_per_gas,
let base_fee = match base_fee {
Some(base_fee) => base_fee,
None => {
// fetch pending base fee
let base_fee = self
@ -311,7 +311,7 @@ pub trait LoadFee: LoadBlock {
Some(max_priority_fee_per_gas) => max_priority_fee_per_gas,
None => self.suggested_priority_fee().await?,
};
Ok((max_fee_per_gas, max_priority_fee_per_gas))
Ok((base_fee, max_priority_fee_per_gas))
}
}